Bug 261242 - [git-webkit] Add screen-reader friendly review wizard
Summary: [git-webkit] Add screen-reader friendly review wizard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
: 273123 (view as bug list)
Depends on: 261246 261277 263652 263653 273781 273784
Blocks:
  Show dependency tree / graph
 
Reported: 2023-09-06 16:43 PDT by Jonathan Bedard
Modified: 2024-05-23 21:05 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-09-06 16:43:09 PDT 
HTML based code review tools are not friendly for blind developers. This was true in bugzilla, although GitHub's review interface is a regression. It seems that other HTML review tools (notably, Bitbucket) have this same problem.

Andres Gonzalez and I proto-typed a text-based command-line review wizard that he was able to utilize to great effect last week. We should clean up and land the code for that wizard.
Comment 1 Radar WebKit Bug Importer 2023-09-06 16:43:40 PDT 
<rdar://problem/115083100>
Comment 2 Jonathan Bedard 2023-09-06 16:44:20 PDT 
Proto-type uploaded in https://github.com/WebKit/WebKit/pull/17187, although that change needs to be divided up to be landed.
Comment 3 Jonathan Bedard 2024-04-23 07:47:49 PDT 
*** Bug 273123 has been marked as a duplicate of this bug. ***
Comment 4 Jonathan Bedard 2024-04-23 07:55:35 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/27628
Comment 5 Jonathan Bedard 2024-05-10 07:35:33 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/28389
Comment 6 EWS 2024-05-23 16:52:13 PDT 
Committed 279244@main (26ef083bdcb3): <https://commits.webkit.org/279244@main>

Reviewed commits have been landed. Closing PR #27628 and removing active labels.
Comment 7 EWS 2024-05-23 21:05:23 PDT 
Committed 279255@main (74313d0521aa): <https://commits.webkit.org/279255@main>

Reviewed commits have been landed. Closing PR #28389 and removing active labels.