RESOLVED FIXED 263653
[webkitscmpy] Caller must provide arguments to remote files_changed 
https://bugs.webkit.org/show_bug.cgi?id=263653
Summary [webkitscmpy] Caller must provide arguments to remote files_changed
Jonathan Bedard
Reported 2023-10-25 07:15:50 PDT
For a local repository, it makes sense for 'files_changed' to be an optional argument (because we can assume that if no git ref is provided, the caller means "files changed in the current checkout" as opposed to "files changed in a specific commit". That logic doesn't apply to a remote repository, where we should raise a ValueError if a caller requests files_changed without specifying some sort of git ref.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-10-25 07:16:02 PDT
<rdar://problem/117473288>
Jonathan Bedard
Comment 2 2023-10-25 07:19:08 PDT
Pull request: https://github.com/WebKit/WebKit/pull/19536
EWS
Comment 3 2023-10-25 09:46:42 PDT
Committed 269765@main (3e615409768a): <https://commits.webkit.org/269765@main> Reviewed commits have been landed. Closing PR #19536 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.