WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
273784
[webkitscmpy] Fix GitHub mock reviewing
https://bugs.webkit.org/show_bug.cgi?id=273784
Summary
[webkitscmpy] Fix GitHub mock reviewing
Jonathan Bedard
Reported
2024-05-06 11:30:07 PDT
Currently, reviewing in our GitHub mock doesn't work, and our unit tests failed to catch this. Fix both our unit tests and the underlying mocks.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-05-06 11:30:22 PDT
<
rdar://problem/127615550
>
Jonathan Bedard
Comment 2
2024-05-06 11:33:24 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/28188
EWS
Comment 3
2024-05-09 15:28:28 PDT
Committed
278592@main
(a53feed8099c): <
https://commits.webkit.org/278592@main
> Reviewed commits have been landed. Closing PR #28188 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug