Bug 259119 – clang-cl can't link WebCore.dll of Windows Release build

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Fujii Hironori]

clang-cl can't link WebCore.dll of Windows Release build.

set CC=clang-cl
set CXX=clang-cl
perl .\Tools\Scripts\build-webkit --release --no-fatal-warnings

FAILED: bin64/WebCore.dll lib64/WebCore.lib 
cmd.exe /C "cd . && "C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe" -E vs_link_dll --intdir=Source\WebCore\CMakeFiles\WebCore.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~1\LLVM\bin\lld-link.exe /nologo @CMakeFiles\WebCore.rsp  /out:bin64\WebCore.dll /implib:lib64\WebCore.lib /pdb:bin64\WebCore.pdb /dll /version:0.0 /machine:x64 /DEBUG /OPT:ICF /OPT:REF /INCREMENTAL:NO /INCREMENTAL:NO  /DELAYLOAD:d3d9.dll /DELAYLOAD:dxva2.dll /DELAYLOAD:evr.dll /DELAYLOAD:mf.dll /DELAYLOAD:mfplat.dll  && cd ."
LINK: command "C:\PROGRA~1\LLVM\bin\lld-link.exe /nologo @CMakeFiles\WebCore.rsp /out:bin64\WebCore.dll /implib:lib64\WebCore.lib /pdb:bin64\WebCore.pdb /dll /version:0.0 /machine:x64 /DEBUG /OPT:ICF /OPT:REF /INCREMENTAL:NO /INCREMENTAL:NO /DELAYLOAD:d3d9.dll /DELAYLOAD:dxva2.dll /DELAYLOAD:evr.dll /DELAYLOAD:mf.dll /DELAYLOAD:mfplat.dll /MANIFEST /MANIFESTFILE:bin64\WebCore.dll.manifest" failed (exit code 1) with the following output:
lld-link: error: undefined symbol: public: static class JSC::Structure * __cdecl JSC::Structure::create(class JSC::VM &, class JSC::JSGlobalObject *, class JSC::JSValue, class JSC::TypeInfo const &, struct JSC::ClassInfo const *, unsigned char, unsigned int)
>>> referenced by Source\WebCore\CMakeFiles\WebCore.dir\page\UserMessageHandlerDescriptor.cpp.obj
>>> referenced by Source\WebCore\CMakeFiles\WebCore.dir\page\UserMessageHandlersNamespace.cpp.obj
>>> referenced by Source\WebCore\CMakeFiles\WebCore.dir\__\__\WebCore\DerivedSources\unified-sources\UnifiedSource-f8afad56-19.cpp.obj

[Fujii Hironori]

Pull request: https://github.com/WebKit/WebKit/pull/15767

[Fujii Hironori]

I fixed this problem in 206542@main (bug#191626), but it was reverted by 213160@main (bug#196315).

[Fujii Hironori]

Pull request: https://github.com/WebKit/WebKit/pull/15827

[Fujii Hironori]

Pull request: https://github.com/WebKit/WebKit/pull/15828

[Fujii Hironori]

Created attachment 467048 [details]
PerformanceTestsResults.html (localPath needs to adjust)

perf test results of 266055@main and the patched.
https://github.com/WebKit/WebKit/commit/b452a308b06b3789c14e95adbd4045b056700b6a

[Fujii Hironori]

Created attachment 467058 [details]
perf test result (--repeat=2)

The perf test is too flaky to say anything.

[Radar WebKit Bug Importer]

<rdar://problem/112490125>

[Fujii Hironori]

Pull request: https://github.com/WebKit/WebKit/pull/15924

[Fujii Hironori]

Created attachment 467107 [details]
perf results of 4e68a14 (266055@main) and patched

Patch: https://github.com/WebKit/WebKit/commit/a4c9a727e28a869d97086499c25134f295e66178

[Fujii Hironori]

Pull request: https://github.com/WebKit/WebKit/pull/16124

[Fujii Hironori]

Created attachment 467136 [details]
perf results of 4e68a14 (266055@main) and patched

Patch: https://github.com/WebKit/WebKit/commit/2d121324ea753ee0e1b2f30815867ff8270761b8

[EWS]

Committed 266932@main (5bd7a22a5bc3): <https://commits.webkit.org/266932@main>

Reviewed commits have been landed. Closing PR #16124 and removing active labels.