WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
258437
Attachment: Move image display from legacy to modern implementation
https://bugs.webkit.org/show_bug.cgi?id=258437
Summary
Attachment: Move image display from legacy to modern implementation
Gerald Squelart
Reported
2023-06-22 22:28:55 PDT
Replace the inner legacy attachment with a standard `<img>` element. <
rdar://105252742
>
Attachments
Add attachment
proposed patch, testcase, etc.
Gerald Squelart
Comment 1
2023-06-22 22:46:31 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/15228
EWS
Comment 2
2023-06-29 04:05:23 PDT
Committed
265615@main
(b0e7ef7b0420): <
https://commits.webkit.org/265615@main
> Reviewed commits have been landed. Closing PR #15228 and removing active labels.
Gerald Squelart
Comment 3
2023-06-29 13:42:19 PDT
Re-opening for pull request
https://github.com/WebKit/WebKit/pull/15421
EWS
Comment 4
2023-06-29 13:51:10 PDT
Committed
265629@main
(61d2643b6fe6): <
https://commits.webkit.org/265629@main
> Reviewed commits have been landed. Closing PR #15421 and removing active labels.
Jonathan Bedard
Comment 5
2023-07-11 15:53:50 PDT
Looks like this flakily regressed fast/attachment/cocoa/wide-attachment-folder-icon.html
Jonathan Bedard
Comment 6
2023-07-11 15:54:01 PDT
https://results.webkit.org/?suite=layout-tests&test=fast%2Fattachment%2Fcocoa%2Fwide-attachment-folder-icon.html
Gerald Squelart
Comment 7
2023-07-11 16:16:12 PDT
Thank you Jonathan. I believe it may have made a few wide-attachment-* tests flaky, because of the way the icon is asynchronously fetched and then loaded into an img. I'm working on
bug 258865
, which should solve this.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug