Bug 258865 – Attachment ref-tests should wait for the icon to be present

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Gerald Squelart]

Attachment ref-tests don't add any delay before a snapshot is taken. However, attachments request their icon asynchronously during their first paint, meaning that if the snapshot is taken after this first paint it will probably not have the icon!
So I'm suspecting that ref-tests don't actually compare icons, and that intermittent failures could be due to the odd case when the icon is available unexpectedly fast.
To fix this, tests should delay the snapshot until all attachments have received their icon.

[Radar WebKit Bug Importer]

<rdar://problem/111764330>

[Gerald Squelart]

Pull request: https://github.com/WebKit/WebKit/pull/15554

[Ryan Haddad]

*** Bug 259127 has been marked as a duplicate of this bug. ***

[Karl Rackler]

REGRESSION (265615@main): [ iOS macOS wk2 ] Four fast/attachment/cocoa/wide-attachment tests are flaky image failures

After landing 265615@main, some wide-attachment-* tests became flaky because of the way the icon is asynchronously fetched and then loaded into an img.

Description:
fast/attachment/cocoa/wide-attachment-folder-icon.html
fast/attachment/cocoa/wide-attachment-icon-from-file-extension.html
fast/attachment/mac/wide-attachment-title-with-rtl.html
fast/attachment/mac/wide-attachment-type-attribute.html

History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=fast%2Fattachment%2Fcocoa%2Fwide-attachment-folder-icon.html&test=fast%2Fattachment%2Fcocoa%2Fwide-attachment-icon-from-file-extension.html&test=fast%2Fattachment%2Fmac%2Fwide-attachment-title-with-rtl.html&test=fast%2Fattachment%2Fmac%2Fwide-attachment-type-attribute.html&platform=mac

Since the resolution is being worked on in this bug, I have marked these tests as flaky image failures here while this issue is investigated.

[EWS]

Test gardening commit 265994@main (b8b69392a0cc): <https://commits.webkit.org/265994@main>

Reviewed commits have been landed. Closing PR #15786 and removing active labels.

[EWS]

Test gardening commit 265870.40@safari-7616-branch (a5090f836a89): <https://commits.webkit.org/265870.40@safari-7616-branch>

Reviewed commits have been landed. Closing PR #692 and removing active labels.

[EWS]

Committed 266144@main (6e502e9d0156): <https://commits.webkit.org/266144@main>

Reviewed commits have been landed. Closing PR #15554 and removing active labels.