RESOLVED FIXED 258844
Attachment: Icon should be hidden when there is progress or a placeholder 
https://bugs.webkit.org/show_bug.cgi?id=258844
Summary Attachment: Icon should be hidden when there is progress or a placeholder
Gerald Squelart
Reported 2023-07-03 21:41:30 PDT
Bug 258437 changed how the attachment icon is implemented: Instead of an inner attachment, it is now an image. Unfortunately in that change, the `HTMLAttachmentElement::updateProgress` function was incorrectly changed and does not properly hide the icon anymore. To fix: In https://github.com/WebKit/WebKit/pull/15228/files#diff-81277d6d3423f470d7dc5e5b8f50ab5b7a766baeeb1a640d66b5db0edd617312L305 , the m_innerLegacyAttachment->set/removeInlineStyleProperty lines should be put back, but operating on m_imageElement instead.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-07-03 21:41:38 PDT
<rdar://problem/111720923>
Gerald Squelart
Comment 2 2023-07-03 22:02:22 PDT
Pull request: https://github.com/WebKit/WebKit/pull/15531
EWS
Comment 3 2023-07-05 18:47:03 PDT
Committed 265785@main (a9b327ab90e2): <https://commits.webkit.org/265785@main> Reviewed commits have been landed. Closing PR #15531 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.