Bug 253876 - [CMake][Win] builtins_generate_combined_header.py is generated twice both in JavaScriptCoreSharedScripts.vcxproj and JSCBuiltins.vcxproj
Summary: [CMake][Win] builtins_generate_combined_header.py is generated twice both in ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-14 00:44 PDT by Fujii Hironori
Modified: 2023-03-14 13:45 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2023-03-14 00:44:41 PDT 
[CMake] builtins_generate_combined_header.py is generated twice both in JavaScriptCoreSharedScripts.vcxproj and JSCBuiltins.vcxproj

Microsoft Playwright team reported

> Error copying file (if different) from "C:/Users/<USERNAME>/webkit/Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_combined_header.py" to "C:/Users/<USERNAME>/webkit/WebKitBuild/Release/JavaScriptCore/Scripts/builtins_generate_combined_header.py".

https://gist.github.com/mxschmitt/4a7c88611109a58646e1016db34204ee

See also:
  Bug 177286 – [CMake][Win] EventTargetInterfaces.h are generated twice
  Bug 198853 – [CMake][Win] CombinedDomains.json is generated twice in JavaScriptCore_CopyPrivateHeaders and JavaScriptCore projects
  Bug 213225 – [CMake][Visual Studio] CombinedDomains.json is generated twice in JavaScriptCore.vcxproj and InspectorBackendCommands.vcxproj
  Bug 213226 – [CMake][Visual Studio] CSSPropertyNames.h is generated twice in WebCore.vcxproj and WebCore_CopyPrivateHeaders.vcxproj
  Bug 220251 – [WinCairo][CMake][MSBuild][ANGLE] entry_points_*.h was generated twice both in LibGLESv2EntryPointsHeaders and GLESv2 projects
  Bug 240556 – [CMake][Visual Studio] JavaScriptCore/DerivedSources/Bytecodes.h is generated twice both in Bytecodes.vcxproj in LLIntSettingsExtractor.vcxproj
Comment 1 Fujii Hironori 2023-03-14 01:05:05 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11484
Comment 2 EWS 2023-03-14 13:45:40 PDT 
Committed 261645@main (158c7837fac4): <https://commits.webkit.org/261645@main>

Reviewed commits have been landed. Closing PR #11484 and removing active labels.