Bug 177286 - [CMake][Win] EventTargetInterfaces.h are generated twice
Summary: [CMake][Win] EventTargetInterfaces.h are generated twice
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
Keywords: InRadar
Depends on:
Reported: 2017-09-20 18:42 PDT by Fujii Hironori
Modified: 2017-09-27 12:21 PDT (History)
6 users (show)

See Also:

Patch (1.76 KB, patch)
2017-09-20 19:40 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2017-09-20 18:42:17 PDT
Some source files are compiled unnecessarily in the incremental build.

The log of WinCairo port clean build:


The log of WinCairo port null incremental build:


In the first clean bulid log, EventTargetInterfaces.h are generated twice in both WebCoreDerivedSources and WebCore projects.

> 22>------ Build started: Project: WebCoreDerivedSources, Configuration: Debug x64 ------
> (...)
> 22>  Generating ../../DerivedSources/WebCore/EventTargetInterfaces.h
> (...)
> 32>------ Build started: Project: WebCore (WebCore\WebCore), Configuration: Debug x64 ------
> (...)
> 32>  Generating ../../DerivedSources/WebCore/EventTargetInterfaces.h
Comment 1 Fujii Hironori 2017-09-20 19:40:03 PDT
Created attachment 321401 [details]
Comment 2 Alex Christensen 2017-09-21 14:29:35 PDT
If you want this to be reviewed, please set the r? flag.
Comment 3 Brent Fulgham 2017-09-22 11:00:01 PDT
Per Arne: Will this change be okay with our internal build? I think so, but you are the expert :-)
Comment 4 Per Arne Vollan 2017-09-22 11:15:42 PDT
(In reply to Brent Fulgham from comment #3)
> Per Arne: Will this change be okay with our internal build? I think so, but
> you are the expert :-)

I think so, since this change is limited to WebCore :)
Comment 5 Brent Fulgham 2017-09-22 11:16:08 PDT
Comment on attachment 321401 [details]

Comment 6 WebKit Commit Bot 2017-09-22 11:44:58 PDT
Comment on attachment 321401 [details]

Clearing flags on attachment: 321401

Committed r222395: <http://trac.webkit.org/changeset/222395>
Comment 7 WebKit Commit Bot 2017-09-22 11:44:59 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-09-27 12:21:10 PDT