RESOLVED FIXED 177286
[CMake][Win] EventTargetInterfaces.h are generated twice 
https://bugs.webkit.org/show_bug.cgi?id=177286
Summary [CMake][Win] EventTargetInterfaces.h are generated twice
Fujii Hironori
Reported 2017-09-20 18:42:17 PDT
Some source files are compiled unnecessarily in the incremental build. The log of WinCairo port clean build: https://gist.github.com/fujii/1a52f7b02ac4e16927b0b34b4b3eb874#file-webkit-win-cairo-clean-build-txt The log of WinCairo port null incremental build: https://gist.github.com/fujii/1a52f7b02ac4e16927b0b34b4b3eb874#file-webkit-win-cairo-incremental-build-txt In the first clean bulid log, EventTargetInterfaces.h are generated twice in both WebCoreDerivedSources and WebCore projects. > 22>------ Build started: Project: WebCoreDerivedSources, Configuration: Debug x64 ------ > (...) > 22> Generating ../../DerivedSources/WebCore/EventTargetInterfaces.h > (...) > 32>------ Build started: Project: WebCore (WebCore\WebCore), Configuration: Debug x64 ------ > (...) > 32> Generating ../../DerivedSources/WebCore/EventTargetInterfaces.h
Attachments
Patch (1.76 KB, patch)
2017-09-20 19:40 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2017-09-20 19:40:03 PDT
Created attachment 321401 [details] Patch
Alex Christensen
Comment 2 2017-09-21 14:29:35 PDT
If you want this to be reviewed, please set the r? flag.
Brent Fulgham
Comment 3 2017-09-22 11:00:01 PDT
Per Arne: Will this change be okay with our internal build? I think so, but you are the expert :-)
Per Arne Vollan
Comment 4 2017-09-22 11:15:42 PDT
(In reply to Brent Fulgham from comment #3) > Per Arne: Will this change be okay with our internal build? I think so, but > you are the expert :-) I think so, since this change is limited to WebCore :)
Brent Fulgham
Comment 5 2017-09-22 11:16:08 PDT
Comment on attachment 321401 [details] Patch r=me
WebKit Commit Bot
Comment 6 2017-09-22 11:44:58 PDT
Comment on attachment 321401 [details] Patch Clearing flags on attachment: 321401 Committed r222395: <http://trac.webkit.org/changeset/222395>
WebKit Commit Bot
Comment 7 2017-09-22 11:44:59 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-09-27 12:21:10 PDT
<rdar://problem/34693106>
Note You need to log in before you can comment on or make changes to this bug.