Bug 198853 – [CMake][Win] CombinedDomains.json is generated twice in JavaScriptCore_CopyPrivateHeaders and JavaScriptCore projects

• Status: RESOLVED
• Resolution: FIXED
• Component: CMake

[Fujii Hironori]

[CMake][Win] CombinedDomains.json is generated twice in JavaScriptCore_CopyPrivateHeaders and JavaScriptCore projects

Here is the excerpt from build log:

> 8>------ Build started: Project: JavaScriptCore_CopyPrivateHeaders, Configuration: Debug x64 ------
> 8>Generating ../../JavaScriptCore/DerivedSources/CombinedDomains.json
> 25>------ Build started: Project: JavaScriptCore (JavaScriptCore\JavaScriptCore), Configuration: Debug x64 ------
> 25>Generating ../../JavaScriptCore/DerivedSources/CombinedDomains.json

This causes unnecessary re-invoking generate-inspector-protocol-bindings.py in incremental builds because generated InspectorBackendDispatchers.cpp file becomes older than input CombinedDomains.json file.

[Fujii Hironori]

Uploaded full build log: https://gist.github.com/fujii/f5b9c0875f50de7f3e1fe244f65fa200

[Fujii Hironori]

Created attachment 372111 [details]
WIP Patch

The fundamental issue of this bug was fixed in CMake side.
https://gitlab.kitware.com/cmake/cmake/issues/16767

However, JavaScriptCore_CopyPrivateHeaders needs to have a direct
or indirect dependency of JavaScriptCore for CMake eliminating
duplicated custom commands.

[Don Olmstead]

Patch is fine I'm just thinking maybe you should put a comment on why its there. Seems like any WEBKIT_COPY_FILES needs to have a direct dependency if any of the headers contain derived sources.

[Fujii Hironori]

I don't see any other issues.

[Fujii Hironori]

Created attachment 372445 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 372445 [details]
Patch

Clearing flags on attachment: 372445

Committed r246587: <https://trac.webkit.org/changeset/246587>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.