WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
245108
Add type for PlatformMouseEvent modifier flags
https://bugs.webkit.org/show_bug.cgi?id=245108
Summary
Add type for PlatformMouseEvent modifier flags
David Kilzer (:ddkilzer)
Reported
2022-09-12 19:17:55 PDT
Add type for PlatformMouseEvent modifier flags. Only Mac and Windows actually use modifier flags on the PlatformMouseEvent object and AFAICT: - The `unsigned` type is not big enough for either the `NSEventModifierFlags` type on macOS or the `WPARAM` type on Windows. - The instance variable is never used on iOS/tvOS/watchOS platforms. - The lack of type may have caused conversion to the wrong enum value in the fix for
Bug 171297
(
188192@main
). Need to check with some experts what MacCatalyst should do in these cases.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-09-12 19:18:34 PDT
<
rdar://problem/99850228
>
David Kilzer (:ddkilzer)
Comment 2
2022-09-12 20:46:39 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/4293
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug