Bug 171297 - REGRESSION(206450): WebKit2PlatformMouseEvent m_modifierFlags not set
Summary: REGRESSION(206450): WebKit2PlatformMouseEvent m_modifierFlags not set
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-25 16:25 PDT by Alex Christensen
Modified: 2017-04-25 21:28 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.46 KB, patch)
2017-04-25 16:26 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-elcapitan (1.07 MB, application/zip)
2017-04-25 17:41 PDT, Build Bot
no flags Details
Patch (11.89 KB, patch)
2017-04-25 18:30 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-04-25 16:25:38 PDT
REGRESSION(206450): WebKit2PlatformMouseEvent m_modifierFlags not set
Comment 1 Alex Christensen 2017-04-25 16:26:08 PDT
Created attachment 308163 [details]
Patch
Comment 2 Geoffrey Garen 2017-04-25 16:36:45 PDT
Comment on attachment 308163 [details]
Patch

r=me
Comment 3 Geoffrey Garen 2017-04-25 16:37:50 PDT
Can we test this by exercising the WK2 API in WebKitTestRunner?
Comment 4 Build Bot 2017-04-25 17:41:56 PDT
Comment on attachment 308163 [details]
Patch

Attachment 308163 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3605679

New failing tests:
webrtc/datachannel/basic.html
Comment 5 Build Bot 2017-04-25 17:41:58 PDT
Created attachment 308175 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Alex Christensen 2017-04-25 18:30:20 PDT
Created attachment 308182 [details]
Patch
Comment 7 Alex Christensen 2017-04-25 18:30:53 PDT
There we go.  I added an API test that failed before and passes now.  No more regressions!
Comment 8 Alex Christensen 2017-04-25 21:28:18 PDT
http://trac.webkit.org/r215790