Bug 47651 - PlatformMouseEvents need to contain modifier flags
Summary: PlatformMouseEvents need to contain modifier flags
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-13 20:54 PDT by Sam Weinig
Modified: 2010-10-13 21:28 PDT (History)
0 users

See Also:


Attachments
Patch (1.24 KB, patch)
2010-10-13 20:57 PDT, Sam Weinig
jhoneycutt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-10-13 20:54:21 PDT
The PlaformMouseEvent class contains modifier flags in two ways, as bits for the four main fields, and as an unsigned for m_modifierFlags. We don't set m_modifierFlags and thus don't get modifiers sent to us in mouseDidMoveOverElement.
Comment 1 Sam Weinig 2010-10-13 20:57:29 PDT
Created attachment 70707 [details]
Patch
Comment 2 Sam Weinig 2010-10-13 21:28:05 PDT
Fixed in http://trac.webkit.org/changeset/69733.