Bug 239885 - Use the same simulated iPhone model for layout tests an API tests
Summary: Use the same simulated iPhone model for layout tests an API tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-28 21:36 PDT by Simon Fraser (smfr)
Modified: 2023-05-23 16:49 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2022-04-28 21:36:25 PDT 
It's confusing that we use iPhone 12 Pro for layout tests, but iPhone 8 for API tests (bug 239867). We need to standardize on one of them.
Comment 1 Radar WebKit Bug Importer 2022-04-28 21:37:38 PDT 
<rdar://problem/92505373>
Comment 2 Sam Sneddon [:gsnedders] 2022-04-29 07:58:16 PDT 
It was bug 231844 which moved LayoutTests from iPhone SE to iPhone 12 (non-Pro).

I'm a bit confused about what's going on with API tests, it looks like it should similarly be using the defaults specified in Tools/Scripts/webkitpy/port/ios_simulator.py?
Comment 3 Ryan Haddad 2022-08-05 13:10:58 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3055
Comment 4 Jonathan Bedard 2023-05-15 14:58:04 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13897
Comment 5 EWS 2023-05-16 07:43:20 PDT 
Committed 264115@main (4518454316d9): <https://commits.webkit.org/264115@main>

Reviewed commits have been landed. Closing PR #13897 and removing active labels.