RESOLVED FIXED256806
Follow-up: Use the same simulated iPhone model for layout tests an API tests 
https://bugs.webkit.org/show_bug.cgi?id=256806
Summary Follow-up: Use the same simulated iPhone model for layout tests an API tests
Robert Jenner
Reported 2023-05-15 14:42:48 PDT
The following tests fail on iOS devices that are iPhone XS and higher. It should be noted that they all pass on iPhone SE: TestWebKitAPI.DragAndDropTests.AvoidPreciseDropNearTopOfTextArea TestWebKitAPI.DragAndDropTests.CanDragImageWhenNotFirstResponder TestWebKitAPI.DragAndDropTests.CanStartDragOnDivWithDraggableAttribute TestWebKitAPI.DragAndDropTests.CanStartDragOnModel TestWebKitAPI.DragAndDropTests.DataTransferTypesOnDragStartForLink TestWebKitAPI.DragAndDropTests.DataTransferTypesOnDragStartForTextSelection TestWebKitAPI.DragAndDropTests.DoNotExposeCrossOriginImageData TestWebKitAPI.DragAndDropTests.DragLiftPreviewDataTransferSetDragImage TestWebKitAPI.DragAndDropTests.EnterAndLeaveEvents TestWebKitAPI.DragAndDropTests.ModernWebArchiveType TestWebKitAPI.DocumentEditingContext.Simple TestWebKitAPI.ImageAnalysisTests.AvoidRedundantTextRecognitionRequests TestWebKitAPI.PDFSnapshot.FullContent TestWebKitAPI.PDFSnapshot.Over200Inches TestWebKitAPI.RequestTextInputContext.FocusedEditableEmptyLine TestWebKitAPI.RequestTextInputContext.FocusedEditableLineWithOnlyLineBreak TestWebKitAPI.RequestTextInputContext.Iframe TestWebKitAPI.RequestTextInputContext.RectContainsEditableNonRootChild TestWebKitAPI.RequestTextInputContext.RectContainsInnerEditableNonRootChild TestWebKitAPI.RequestTextInputContext.RectContainsNestedEditableNonRootChild TestWebKitAPI.RequestTextInputContext.Simple TestWebKitAPI.RequestTextInputContext.TextInteraction_HighlightSelectedText TestWebKitAPI.RestoreScrollPositionTests.RestoreScrollPositionAfterBack TestWebKitAPI.ScrollViewInsetTests.ChangeInsetWithoutAutomaticAdjustmentWhileWebProcessIsUnresponsive TestWebKitAPI.ScrollViewInsetTests.InnerHeightWithLargeBottomContentInset TestWebKitAPI.ScrollViewInsetTests.RestoreInitialContentOffsetAfterCrash TestWebKitAPI.ScrollViewInsetTests.RestoreInitialContentOffsetAfterCrashWithAsyncPolicyDelegates TestWebKitAPI.ScrollViewInsetTests.RestoreInitialContentOffsetAfterNavigation TestWebKitAPI.TrackingPrevention.HideScreenSizeWithScaledPage TestWebKitAPI.TrackingPrevention.VerifyHashFromNoisyCanvas2DAPI TestWebKitAPI.TrackingPrevention.VerifyPixelsFromNoisyCanvas2DAPI TestWebKitAPI.WKAttachmentTests.DropFolderAsAttachmentAndMoveByDragging TestWebKitAPI.WKAttachmentTestsIOS.DragAttachmentInsertedAsFile TestWebKitAPI.WKAttachmentTestsIOS.InsertDroppedAttributedStringContainingAttachment TestWebKitAPI.WKAttachmentTestsIOS.InsertDroppedImageAsAttachment TestWebKitAPI.WKAttachmentTestsIOS.InsertDroppedImageWithNonImageFileExtension TestWebKitAPI.WKAttachmentTestsIOS.InsertDroppedImageWithPreferredPresentationSize TestWebKitAPI.WKAttachmentTestsIOS.InsertDroppedItemProvidersInOrder TestWebKitAPI.WKAttachmentTestsIOS.InsertDroppedRichAndPlainTextFilesAsAttachments TestWebKitAPI.WKAttachmentTestsIOS.InsertDroppedZipArchiveAsAttachment TestWebKitAPI.WKAttachmentTestsIOS.InsertPastedContactAsAttachment TestWebKitAPI.WKAttachmentTestsIOS.TargetedPreviewIsClippedWhenDroppingTallImage TestWebKitAPI.WKScrollViewTests.PositionFixedLayerAfterScrolling TestWebKitAPI.WKWebView.SnapshotAfterScreenUpdates TestWebKitAPI.WKWebView.SnapshotImageBaseCase TestWebKitAPI.WKWebView.SnapshotWithoutAfterScreenUpdates TestWebKitAPI.WebKit.OverrideViewportArguments TestWebKitAPI.WebKit.VisibleContentRect_ClippedBoundsWhenClippedByEnclosingView TestWebKitAPI.WebKit.VisibleContentRect_ClippedBoundsWhenClippedByScrollView TestWebKitAPI.WebKit.VisibleContentRect_FullBoundsWhenClippedByNonScrollView TestWebKitAPI.WebKitLegacy.RenderInContextSnapshot TestWebKitAPI._WKActivatedElementInfo.HitTestPointOutsideView TestWebKitAPI._WKActivatedElementInfo.InfoForBlank TestWebKitAPI._WKActivatedElementInfo.InfoForLink Adjustments to these tests will need to be made to take into account a device with a larger edge to edge screen, such as an iPhone XS or higher, or a device with a dynamic island (iPhone 14)
Attachments
Add attachment proposed patch, testcase, etc.
Robert Jenner
Comment 1 2023-05-15 14:43:18 PDT
<rdar://problem/109372419>
Robert Jenner
Comment 2 2023-05-23 15:53:38 PDT
*** This bug has been marked as a duplicate of bug 256860 ***
Robert Jenner
Comment 3 2023-05-23 16:45:58 PDT
The majority of these tests were fixed in: https://commits.webkit.org/264150@main The rest have been filed: https://bugs.webkit.org/show_bug.cgi?id=257239 https://bugs.webkit.org/show_bug.cgi?id=257235 https://bugs.webkit.org/show_bug.cgi?id=257228 and are currently being worked on. That being said, I think we can put up a PR to switch our API simulator for API tests from iPhone SE, to iPhone 12.
Robert Jenner
Comment 4 2023-05-23 16:47:22 PDT
Re-opening to land a config change after all of these tests have been addressed.
EWS
Comment 5 2023-05-24 15:13:15 PDT
Committed 264487@main (c0733478cc6a): <https://commits.webkit.org/264487@main> Reviewed commits have been landed. Closing PR #14275 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.