Bug 239867 - REGRESSION (249864@main): [ iOS ] TestWebKitAPI.ScrollViewScrollabilityTests.ScrollableWithOverflowHiddenAndShrunkUI is failing
Summary: REGRESSION (249864@main): [ iOS ] TestWebKitAPI.ScrollViewScrollabilityTests....
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
Keywords: InRadar
Depends on:
Reported: 2022-04-28 13:26 PDT by Truitt Savell
Modified: 2022-04-29 12:26 PDT (History)
6 users (show)

See Also:

Patch (2.25 KB, patch)
2022-04-28 21:37 PDT, Simon Fraser (smfr)
sam: review+
Details | Formatted Diff | Diff
Patch (2.38 KB, patch)
2022-04-29 10:35 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2022-04-28 13:26:00 PDT
This test is a constant failure on iOS. this began with the changes in https://github.com/WebKit/WebKit/commit/681a897dc791f36df24e247cd4f466da669a0052 according to history. 



        Expected equality of these values:
          [[webView scrollView] isScrollEnabled]
            Which is: false
            Which is: true
Comment 1 Radar WebKit Bug Importer 2022-04-28 13:26:19 PDT
Comment 2 Simon Fraser (smfr) 2022-04-28 20:50:19 PDT
I think this might be because I wrote the tests to work in the iPhone 12 simulator but we run them in the iPhone 8 simulator
Comment 3 Simon Fraser (smfr) 2022-04-28 21:37:45 PDT
Created attachment 458569 [details]
Comment 4 Sam Weinig 2022-04-29 10:26:21 PDT
Comment on attachment 458569 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=458569&action=review

> Tools/TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:127
> +    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, viewHeight, 375)]);

Probably worth a comment about where the value comes from.

> Tools/TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:137
> +    [webView _overrideLayoutParametersWithMinimumLayoutSize:CGSizeMake(viewHeight, 325) maximumUnobscuredSizeOverride:CGSizeMake(viewHeight, 375)];

Probably worth a comment about where the value comes from.
Comment 5 Simon Fraser (smfr) 2022-04-29 10:35:49 PDT
Created attachment 458593 [details]
Comment 6 EWS 2022-04-29 12:26:40 PDT
Committed r293626 (250132@main): <https://commits.webkit.org/250132@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458593 [details].