TestWebKitAPI.ScrollViewScrollabilityTests.ScrollableWithOverflowHiddenAndShrunkUI This test is a constant failure on iOS. this began with the changes in https://github.com/WebKit/WebKit/commit/681a897dc791f36df24e247cd4f466da669a0052 according to history. History: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.ScrollViewScrollabilityTests.ScrollableWithOverflowHiddenAndShrunkUI Diff: /Volumes/Data/worker/Apple-iOS-15-Simulator-Release-Build/build/Tools/TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:141 Expected equality of these values: [[webView scrollView] isScrollEnabled] Which is: false __objc_yes Which is: true
<rdar://problem/92483866>
I think this might be because I wrote the tests to work in the iPhone 12 simulator but we run them in the iPhone 8 simulator
Created attachment 458569 [details] Patch
Comment on attachment 458569 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458569&action=review > Tools/TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:127 > + auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, viewHeight, 375)]); Probably worth a comment about where the value comes from. > Tools/TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:137 > + [webView _overrideLayoutParametersWithMinimumLayoutSize:CGSizeMake(viewHeight, 325) maximumUnobscuredSizeOverride:CGSizeMake(viewHeight, 375)]; Probably worth a comment about where the value comes from.
Created attachment 458593 [details] Patch
Committed r293626 (250132@main): <https://commits.webkit.org/250132@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458593 [details].