Bug 238832 – Fix expected, actual links for variant-based imported wpt tests

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Website

[[e-mail]]

Appears these aren't working on ex: https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r292391%20(6950)/results.html

[Radar WebKit Bug Importer]

<rdar://problem/91313891>

[[e-mail]]

I wiped out the associated change in results.html from https://bugs.webkit.org/show_bug.cgi?id=231544 when preparing it for a patch. Will add in this bug.

[[e-mail]]

Created attachment 456758 [details]
Patch

[[e-mail]]

Created attachment 456825 [details]
Patch

[Brent Fulgham]

Comment on attachment 456825 [details]
Patch

r=me. Thanks for putting together a more complete/future-proof fix!

[EWS]

Committed r292508 (249351@main): <https://commits.webkit.org/249351@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456825 [details].

[Nikolas Zimmermann]

I can no longer open differences/expected/actual files for SVG files, if they fail.
Since this is the only code that touches the "output_filename" function in a while, it must be guilty for this.

[Nikolas Zimmermann]

(In reply to Nikolas Zimmermann from comment #7)
> I can no longer open differences/expected/actual files for SVG files, if
> they fail.
> Since this is the only code that touches the "output_filename" function in a
> while, it must be guilty for this.

Some context: if e.g. svg/W3C-SVG-1.1/animate-elem-02-t.svg fails, the generated results.html now contains links to "file:///Users/nzimmermann/Software/GitRepositories/WebKitVanilla/WebKitBuild/Release/layout-test-results/svg/W3C-SVG-1.1/animate-elem-02-t.svg-diffs.html"

The ".svg" is superfluous and thus the link points to nirvana now.

[Nikolas Zimmermann]

(In reply to Nikolas Zimmermann from comment #8)
> (In reply to Nikolas Zimmermann from comment #7)
> > I can no longer open differences/expected/actual files for SVG files, if
> > they fail.
> > Since this is the only code that touches the "output_filename" function in a
> > while, it must be guilty for this.
> 
> Some context: if e.g. svg/W3C-SVG-1.1/animate-elem-02-t.svg fails, the
> generated results.html now contains links to
> "file:///Users/nzimmermann/Software/GitRepositories/WebKitVanilla/
> WebKitBuild/Release/layout-test-results/svg/W3C-SVG-1.1/animate-elem-02-t.
> svg-diffs.html"
> 
> The ".svg" is superfluous and thus the link points to nirvana now.


The JS code in LayoutTests/fast/harness/results.html implements the 'static testPrefix' method, which contains following check:

         else if (Utils.splitExtension(parts[0])[1].length > 5) {

Utils.splitExtension(parts[0]) returns "["svg/W3C-SVG-1", "1/shapes-rect-01-t"] in my case -- it treats the dot in the folder name as file extension.

The implementation of Utils.splitExtension() needs to be reworked:

    static splitExtension(testName)
    {
        let index = testName.lastIndexOf('.');
        if (index == -1) {
            return [testName, ''];
        }
        return [testName.substring(0, index), testName.substring(index + 1)];
    }

Ok, I'll revert it locally for now, so that I can proceed to do what I actually wanted :-) Feel free to proceed with a fix rather than a roll-out. I'm happy to cross check your patch.

[Nikolas Zimmermann]

This is hitting other folks as well, heard the question now two times already in Igaia, why results.html pages are broken.

[Philippe Normand]

Pull request: https://github.com/WebKit/WebKit/pull/6143

[EWS]

Committed 256703@main (3be2c0d6c2ab): <https://commits.webkit.org/256703@main>

Reviewed commits have been landed. Closing PR #6143 and removing active labels.

[Simon Fraser (smfr)]

This is still broken: bug 248745