Bug 238618 – RemoteRenderingBackendProxy fails to maintain correct state when gpu process crashes and upon deletion

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Kimmo Kinnunen]

RemoteRenderingBackendProxy fails to maintain correct state when gpu process crashes and upon deletion

[Kimmo Kinnunen]

Created attachment 456257 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 456257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456257&action=review

> Source/WebKit/ChangeLog:3
> +        RemoteRenderingBackendProxy fails to maintain correct state when gpu process crashes and upon deletion

But this doesn't fix the issue where the GPU Process crashes while we're blocked on the m_wakeUpSemaphore, right?

> Source/WebKit/Platform/IPC/MessageReceiveQueueMap.cpp:64
> +            ALWAYS_LOG_WITH_STREAM(stream << "MessageReceiveQueueMap::addImpl - adding duplicate any id receiver " << static_cast<uint8_t>(receiverName));

When debugging I wanted a TextStream& operator<<(TextStream&, ReceiverName). Maybe we should add one, or do some kind of IPC::description() thing that makes them easy to print.

[Kimmo Kinnunen]

Created attachment 456268 [details]
Patch

[Kimmo Kinnunen]

> But this doesn't fix the issue where the GPU Process crashes while we're blocked on the m_wakeUpSemaphore, right?

No, this doesn't address it. Will work on it next week.

>> Source/WebKit/Platform/IPC/MessageReceiveQueueMap.cpp:64
>> +            ALWAYS_LOG_WITH_STREAM(stream << "MessageReceiveQueueMap::addImpl - adding duplicate any id receiver " << static_cast<uint8_t>(receiverName));

In fact this was a botched hunk that belonged to previous patch.

> When debugging I wanted a TextStream& operator<<(TextStream&, ReceiverName). Maybe we should add one, or do some kind of IPC::description() thing that makes them easy to print.

Added bug 238624, can do that tomorrow.

[Kimmo Kinnunen]

Created attachment 456558 [details]
For landing

[EWS]

Committed r292289 (249187@main): <https://commits.webkit.org/249187@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456558 [details].

[Radar WebKit Bug Importer]

<rdar://problem/91241701>

[Said Abou-Hallawa]

*** Bug 237295 has been marked as a duplicate of this bug. ***