Bug 237311 - Unable to set logging channel levels through NSUserDefaults in Release builds
Summary: Unable to set logging channel levels through NSUserDefaults in Release builds
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-01 00:35 PST by Kimmo Kinnunen
Modified: 2022-03-08 00:36 PST (History)
8 users (show)

See Also:

Attachments
Patch (13.60 KB, patch)
2022-03-01 01:13 PST, Kimmo Kinnunen 		jer.noble: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-03-01 00:35:14 PST 
Unable to set logging channel levels through NSUserDefaults in Release builds

Regressed in bug 233360

Jer Noble 2022-02-24 20:02:47 PST
> In bug 227822, we showed that logLevelString() returns the empty string for release builds. This patch undid that change, and returned the previous behavior of effectively disabling all non-error logging in release builds, affecting our ability to collect debug logs with a NSUserDefaults change.
Comment 1 Kimmo Kinnunen 2022-03-01 01:13:33 PST 
Created attachment 453479 [details]
Patch
Comment 2 Jer Noble 2022-03-01 10:40:39 PST 
Lets not do this. We've have regressions in process launch time in the past that were due to reading NSDefaults during process launch.
Comment 3 Jer Noble 2022-03-01 10:44:19 PST 
Comment on attachment 453479 [details]
Patch

Moving from r+ to r-; reading NSDefaults during process launch has caused process launch time regressions in the past. See bug #185951 for context.

With the change from r290654 in place, we should only be reading NSDefaults once during app launch, then never again, so this change should be unnecessary.
Comment 4 Radar WebKit Bug Importer 2022-03-08 00:36:15 PST 
<rdar://problem/89954192>