Bug 233360 - Network process does not seem to initialize logging
Summary: Network process does not seem to initialize logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-19 04:48 PST by Kimmo Kinnunen
Modified: 2022-03-01 00:35 PST (History)
9 users (show)

See Also:

Attachments
Patch (40.89 KB, patch)
2021-12-02 01:44 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (40.70 KB, patch)
2021-12-02 01:48 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-11-19 04:48:01 PST 
Network process does not seem to initialize logging
 
Tools/Scripts/run-minibrowser --debug -WebKit2Logging IPCMessages does not seem to print IPC logging for network process.
Comment 1 Radar WebKit Bug Importer 2021-11-26 04:48:20 PST 
<rdar://problem/85765854>
Comment 2 Kimmo Kinnunen 2021-12-02 01:44:03 PST 
Created attachment 445693 [details]
Patch
Comment 3 Kimmo Kinnunen 2021-12-02 01:48:38 PST 
Created attachment 445694 [details]
Patch
Comment 4 Fujii Hironori 2021-12-02 20:15:12 PST 
Comment on attachment 445694 [details]
Patch

Because GTK, WPE and Windows ports are using env vars for logging settings, they don't need this change. However, I think this is a good idea. LGTM.
Comment 5 EWS 2021-12-03 00:06:18 PST 
Committed r286484 (244823@main): <https://commits.webkit.org/244823@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445694 [details].
Comment 6 Jer Noble 2022-02-24 20:00:05 PST 
This change broke the ability to set logging channel levels through NSUserDefaults.
Comment 7 Jer Noble 2022-02-24 20:02:47 PST 
In r227822, we showed that logLevelString() returns the empty string for release builds. This patch undid that change, and returned the previous behavior of effectively disabling all non-error logging in release builds, affecting our ability to collect debug logs with a NSUserDefaults change.