Bug 185951 – Some of the work in initializeLogChannelsIfNecessary() is unnecessary for release builds

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

Some of the work in initializeLogChannelsIfNecessary() is unnecessary for release builds and slows down launch time. In particular, it is unnecessary to read NSDefaults to figure out which logging channels should be enabled.

[Chris Dumez]

Sample Count, Samples %, CPU %, Symbol
17, 0.2%, 0.1%, WebKit::InitializeWebKit2() (in WebKit)
17, 0.2%, 0.1%,     std::__1::__call_once(unsigned long volatile&, void*, void (*)(void*)) (in libc++.1.dylib)
17, 0.2%, 0.1%,         WebKit::runInitializationCode(void*) (in WebKit)
11, 0.1%, 0.1%,             WebCore::initializeLogChannelsIfNecessary(std::optional<WTF::String>) (in WebCore)
6, 0.1%, 0.0%,                 WebCore::logLevelString() (in WebCore)
5, 0.1%, 0.0%,                     +[NSUserDefaults(NSUserDefaults) standardUserDefaults] (in Foundation)
5, 0.1%, 0.0%,                         -[NSUserDefaults(NSUserDefaults) init] (in Foundation)
5, 0.1%, 0.0%,                             +[NSLocale currentLocale] (in CoreFoundation)
1, 0.0%, 0.0%,                     -[NSUserDefaults(NSUserDefaults) stringForKey:] (in Foundation)
5, 0.1%, 0.0%,                 WTFInitializeLogChannelStatesFromString (in JavaScriptCore)
5, 0.1%, 0.0%,                     os_log_create (in libsystem_trace.dylib)

[Chris Dumez]

Created attachment 341204 [details]
Patch

[Geoffrey Garen]

Comment on attachment 341204 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 341204 [details]
Patch

Clearing flags on attachment: 341204

Committed r232158: <https://trac.webkit.org/changeset/232158>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/40530243>