Bug 236181 - [WTF] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings in CompletionHandler.h
Summary: [WTF] Fix clang tidy bugprone-move-forwarding-reference static analyzer warni...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-05 12:39 PST by David Kilzer (:ddkilzer)
Modified: 2022-02-10 12:37 PST (History)
7 users (show)

See Also:


Attachments
Patch v1 (2.05 KB, patch)
2022-02-05 12:40 PST, David Kilzer (:ddkilzer)
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch v2 (2.07 KB, patch)
2022-02-05 13:04 PST, David Kilzer (:ddkilzer)
ysuzuki: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2022-02-05 12:39:09 PST
Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings in CompletionHandler.h.

Found by clang static analyzer.
Comment 1 Radar WebKit Bug Importer 2022-02-05 12:39:25 PST
<rdar://problem/88529996>
Comment 2 David Kilzer (:ddkilzer) 2022-02-05 12:40:17 PST
Created attachment 450995 [details]
Patch v1
Comment 3 David Kilzer (:ddkilzer) 2022-02-05 13:04:17 PST
Created attachment 450996 [details]
Patch v2
Comment 4 David Kilzer (:ddkilzer) 2022-02-05 13:05:02 PST
(In reply to David Kilzer (:ddkilzer) from comment #2)
> Created attachment 450995 [details]
> Patch v1

Oops.  Changed std::forward() to std::forward<CallableType>().
Comment 5 David Kilzer (:ddkilzer) 2022-02-05 15:05:27 PST
Comment on attachment 450996 [details]
Patch v2

Marking xq+ since enough builds and tests have run to show this didn't cause a regression.
Comment 6 EWS 2022-02-05 15:40:14 PST
Committed r289162 (246858@main): <https://commits.webkit.org/246858@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450996 [details].
Comment 7 Yusuke Suzuki 2022-02-05 20:16:10 PST
Comment on attachment 450996 [details]
Patch v2

r=me, yes, it can be a lref or rref (b/c CallableType is template type of this function), thus we should use std::forward.
Comment 8 Yusuke Suzuki 2022-02-05 20:16:32 PST
Ah, oops it was already landed.