RESOLVED FIXED 236181
[WTF] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings in CompletionHandler.h 
https://bugs.webkit.org/show_bug.cgi?id=236181
Summary [WTF] Fix clang tidy bugprone-move-forwarding-reference static analyzer warni...
David Kilzer (:ddkilzer)
Reported 2022-02-05 12:39:09 PST
Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings in CompletionHandler.h. Found by clang static analyzer.
Attachments
Patch v1 (2.05 KB, patch)
2022-02-05 12:40 PST, David Kilzer (:ddkilzer) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch v2 (2.07 KB, patch)
2022-02-05 13:04 PST, David Kilzer (:ddkilzer) 		ysuzuki: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-02-05 12:39:25 PST
<rdar://problem/88529996>
David Kilzer (:ddkilzer)
Comment 2 2022-02-05 12:40:17 PST
Created attachment 450995 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 3 2022-02-05 13:04:17 PST
Created attachment 450996 [details] Patch v2
David Kilzer (:ddkilzer)
Comment 4 2022-02-05 13:05:02 PST
(In reply to David Kilzer (:ddkilzer) from comment #2) > Created attachment 450995 [details] > Patch v1 Oops. Changed std::forward() to std::forward<CallableType>().
David Kilzer (:ddkilzer)
Comment 5 2022-02-05 15:05:27 PST
Comment on attachment 450996 [details] Patch v2 Marking xq+ since enough builds and tests have run to show this didn't cause a regression.
EWS
Comment 6 2022-02-05 15:40:14 PST
Committed r289162 (246858@main): <https://commits.webkit.org/246858@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450996 [details].
Yusuke Suzuki
Comment 7 2022-02-05 20:16:10 PST
Comment on attachment 450996 [details] Patch v2 r=me, yes, it can be a lref or rref (b/c CallableType is template type of this function), thus we should use std::forward.
Yusuke Suzuki
Comment 8 2022-02-05 20:16:32 PST
Ah, oops it was already landed.
Note You need to log in before you can comment on or make changes to this bug.