Bug 229114 – [WTF] Fix static analyzer warnings for clang tidy bugprone-move-forwarding-reference checker

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[David Kilzer (:ddkilzer)]

Fix static analyzer warnings in WTF for clang tidy bugprone-move-forwarding-reference checker.

See:  <https://clang.llvm.org/extra/clang-tidy/checks/bugprone-move-forwarding-reference.html>

In file included from OpenSource/Source/WTF/wtf/AutomaticThread.cpp:27:
In file included from WebKitBuild/usr/local/include/wtf/AutomaticThread.h:29:
In file included from WebKitBuild/usr/local/include/wtf/Condition.h:30:
In file included from WebKitBuild/usr/local/include/wtf/ParkingLot.h:29:
WebKitBuild/usr/local/include/wtf/ScopedLambda.h:128:55: warning: Forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead
    return ScopedLambdaFunctor<FunctionType, Functor>(WTFMove(functor));
                                                      ^
In file included from OpenSource/Source/WTF/wtf/AutomaticThread.cpp:26:
In file included from OpenSource/Source/WTF/config.h:31:
In file included from WebKitBuild/usr/local/include/wtf/FastMalloc.h:26:
WebKitBuild/usr/local/include/wtf/StdLibExtras.h:568:24: note: expanded from macro 'WTFMove'
#define WTFMove(value) std::move<WTF::CheckMoveParameter>(value)
                       ^

[David Kilzer (:ddkilzer)]

Created attachment 435551 [details]
Patch v1

[EWS]

Committed r281270 (240695@main): <https://commits.webkit.org/240695@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435551 [details].

[Radar WebKit Bug Importer]

<rdar://problem/82142002>