RESOLVED FIXED 236459
[WTF] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings from WebCore/WebKit
https://bugs.webkit.org/show_bug.cgi?id=236459
Summary [WTF] Fix clang tidy bugprone-move-forwarding-reference static analyzer warni...
David Kilzer (:ddkilzer)
Reported 2022-02-10 12:37:53 PST
[WTF] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings from WebCore/WebKit. Found by clang static analyzer.
Attachments
Patch v1 (2.01 KB, patch)
2022-02-10 12:39 PST, David Kilzer (:ddkilzer)
no flags
Radar WebKit Bug Importer
Comment 1 2022-02-10 12:38:29 PST
David Kilzer (:ddkilzer)
Comment 2 2022-02-10 12:39:29 PST
Created attachment 451588 [details] Patch v1
Darin Adler
Comment 3 2022-02-10 13:56:48 PST
Comment on attachment 451588 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=451588&action=review > Source/WTF/wtf/IteratorAdaptors.h:110 > template<typename Transform, typename Iterator> > inline TransformIterator<Transform, Iterator> makeTransformIterator(Transform&& transform, Iterator&& iter) > { > - return TransformIterator<Transform, Iterator>(WTFMove(transform), WTFMove(iter)); > + return TransformIterator<Transform, Iterator>(std::forward<Transform>(transform), std::forward<Iterator>(iter)); > } We should dump this function and take advantage of deduction guides instead. OK to fix it for now, though.
David Kilzer (:ddkilzer)
Comment 4 2022-02-10 20:30:12 PST
Comment on attachment 451588 [details] Patch v1 Marking cq+ as enough bots have built and tested for this change.
EWS
Comment 5 2022-02-10 21:18:56 PST
Committed r289602 (247115@main): <https://commits.webkit.org/247115@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451588 [details].
Note You need to log in before you can comment on or make changes to this bug.