Bug 236459 – [WTF] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings from WebCore/WebKit

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[David Kilzer (:ddkilzer)]

[WTF] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings from WebCore/WebKit.

Found by clang static analyzer.

[Radar WebKit Bug Importer]

<rdar://problem/88772313>

[David Kilzer (:ddkilzer)]

Created attachment 451588 [details]
Patch v1

[Darin Adler]

Comment on attachment 451588 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=451588&action=review

> Source/WTF/wtf/IteratorAdaptors.h:110
>  template<typename Transform, typename Iterator>
>  inline TransformIterator<Transform, Iterator> makeTransformIterator(Transform&& transform, Iterator&& iter)
>  {
> -    return TransformIterator<Transform, Iterator>(WTFMove(transform), WTFMove(iter));
> +    return TransformIterator<Transform, Iterator>(std::forward<Transform>(transform), std::forward<Iterator>(iter));
>  }

We should dump this function and take advantage of deduction guides instead. OK to fix it for now, though.

[David Kilzer (:ddkilzer)]

Comment on attachment 451588 [details]
Patch v1

Marking cq+ as enough bots have built and tested for this change.

[EWS]

Committed r289602 (247115@main): <https://commits.webkit.org/247115@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451588 [details].