Bug 235299 – Improve git-webkit pr error message

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

Below is the error message which I got when 'git-webkit pr' failed. This isn't very informative and doesn't clearly tell what is the problem. There are couple of things which can be improved in it. e.g.: it should list the name of the repository which wasn't found, it should list the fork (e.g.: [e-mail]:username/WebKit.git). It can even suggest to re-run 'git-webkit setup' assuming that can potentially fix the problem (See Bug 235297 and Bug 235298).


[WebKit]$git-webkit pr
From github.com:WebKit/WebKit
 * branch                      main       -> FETCH_HEAD
Current branch eng/235296 is up to date.
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
Failed to push 'eng/235296' to 'fork'

[Jonathan Bedard]

(In reply to Aakash Jain from comment #0)
> Below is the error message which I got when 'git-webkit pr' failed. This
> isn't very informative and doesn't clearly tell what is the problem. There
> are couple of things which can be improved in it. e.g.: it should list the
> name of the repository which wasn't found, it should list the fork (e.g.:
> [e-mail]:username/WebKit.git). It can even suggest to re-run
> 'git-webkit setup' assuming that can potentially fix the problem (See Bug
> 235297 and Bug 235298).
> 
> 
> [WebKit]$git-webkit pr
> From github.com:WebKit/WebKit
>  * branch                      main       -> FETCH_HEAD
> Current branch eng/235296 is up to date.
> ERROR: Repository not found.
> fatal: Could not read from remote repository.
> 
> Please make sure you have the correct access rights
> and the repository exists.
> Failed to push 'eng/235296' to 'fork'

Kicker here is that other than the final error message, those are actually coming directly from `git`, not `git-webkit` script. So we can't easily change them. But we can give some resolution advice.

[Radar WebKit Bug Importer]

<rdar://problem/87721181>

[Jonathan Bedard]

Pull-request: https://github.com/WebKit/WebKit/pull/76

[Jonathan Bedard]

Landed 246182@main (r288222)