Bug 235297 - git-webkit setup should allow changing the credentials
Summary: git-webkit setup should allow changing the credentials
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
Keywords: InRadar
Depends on: 236539
  Show dependency treegraph
Reported: 2022-01-17 13:55 PST by Aakash Jain
Modified: 2022-03-09 08:29 PST (History)
4 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2022-01-17 13:55:17 PST
git-webkit setup show allow changing the credentials. In case user made a mistake and entered incorrect credentials, there should be a way to either correct that or enter new credentials. Perhaps it can ask user if they want to update the stored credentials, and re-configure the correct remotes appropriately.
Comment 1 Radar WebKit Bug Importer 2022-01-24 13:56:16 PST
Comment 2 Jonathan Bedard 2022-02-08 15:26:39 PST
I think users would get a bit annoyed if their credentials were correct and we prompted them to validate them. My proposed change here is that we make an attempt to validate the user's credentials and prompt them only if the validation fails. I also think this applies to bugzilla credentials.
Comment 3 Jonathan Bedard 2022-02-08 15:46:45 PST
Pull request: https://github.com/WebKit/WebKit/pull/133
Comment 4 Jonathan Bedard 2022-02-11 18:05:22 PST
Landed 247173@main (r289687)
Comment 5 WebKit Commit Bot 2022-02-12 06:18:22 PST
Re-opened since this is blocked by bug 236539
Comment 6 Jonathan Bedard 2022-02-15 11:07:24 PST
247173@main (r289687) really should have been associated to https://bugs.webkit.org/show_bug.cgi?id=235298. I fixed the issue and re-landed that change.

I am going to close this as 'WONTFIX' because I think it will make `git-webkit setup` worse. I think that the validation will, in practice, do a good job of covering the use case in mind here, because I don't think someone having valid credentials in their keychain would want to overwrite them with different credentials, I think they would only want to overwrite invalid credentials, which is covered very well by https://bugs.webkit.org/show_bug.cgi?id=235298