WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
235297
git-webkit setup should allow changing the credentials
https://bugs.webkit.org/show_bug.cgi?id=235297
Summary
git-webkit setup should allow changing the credentials
Aakash Jain
Reported
2022-01-17 13:55:17 PST
git-webkit setup show allow changing the credentials. In case user made a mistake and entered incorrect credentials, there should be a way to either correct that or enter new credentials. Perhaps it can ask user if they want to update the stored credentials, and re-configure the correct remotes appropriately.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-01-24 13:56:16 PST
<
rdar://problem/87988794
>
Jonathan Bedard
Comment 2
2022-02-08 15:26:39 PST
I think users would get a bit annoyed if their credentials were correct and we prompted them to validate them. My proposed change here is that we make an attempt to validate the user's credentials and prompt them only if the validation fails. I also think this applies to bugzilla credentials.
Jonathan Bedard
Comment 3
2022-02-08 15:46:45 PST
Pull request:
https://github.com/WebKit/WebKit/pull/133
Jonathan Bedard
Comment 4
2022-02-11 18:05:22 PST
Landed
247173@main
(
r289687
)
WebKit Commit Bot
Comment 5
2022-02-12 06:18:22 PST
Re-opened since this is blocked by
bug 236539
Jonathan Bedard
Comment 6
2022-02-15 11:07:24 PST
247173@main
(
r289687
) really should have been associated to
https://bugs.webkit.org/show_bug.cgi?id=235298
. I fixed the issue and re-landed that change. I am going to close this as 'WONTFIX' because I think it will make `git-webkit setup` worse. I think that the validation will, in practice, do a good job of covering the use case in mind here, because I don't think someone having valid credentials in their keychain would want to overwrite them with different credentials, I think they would only want to overwrite invalid credentials, which is covered very well by
https://bugs.webkit.org/show_bug.cgi?id=235298
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug