RESOLVED FIXED 235298
git-webkit setup should verify the credentials before saving them 
https://bugs.webkit.org/show_bug.cgi?id=235298
Summary git-webkit setup should verify the credentials before saving them
Aakash Jain
Reported 2022-01-17 13:58:13 PST
git-webkit setup should verify the credentials before saving them. When I run git-webkit setup first time, I entered incorrect credentials (e.g.: email instead of username). git-webkit happily accepted the credentials, and configured incorrect remote based on those incorrect credentials. There should be some kind of validation before saving the credentials to ensure that credentials are correct.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-01-24 13:59:15 PST
<rdar://problem/87988965>
Jonathan Bedard
Comment 2 2022-02-15 11:03:58 PST
I incorrectly associated 247173@main (r289687) with https://bugs.webkit.org/show_bug.cgi?id=235297, when it really fixed this bug. That change was reverted in 247175@main (r289690) because I had forgotten to cover the not-required case and broke commit queue. I have re-landed this change in 247283@main (r289835), fixing that problem. Note that verification only happens when the caller requests it, and we only request verification in `git-webkit setup`
Note You need to log in before you can comment on or make changes to this bug.