Bug 234024 - [GPU Process] [Filters] Add the encoding and decoding for SVGFilter
Summary: [GPU Process] [Filters] Add the encoding and decoding for SVGFilter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 231253 233989 234027
  Show dependency tree / graph
 
Reported: 2021-12-08 11:59 PST by Said Abou-Hallawa
Modified: 2021-12-08 16:38 PST (History)
15 users (show)

See Also:

Attachments
Patch (18.12 KB, patch)
2021-12-08 12:17 PST, Said Abou-Hallawa 		wenson_hsieh: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (18.19 KB, patch)
2021-12-08 12:39 PST, Said Abou-Hallawa 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (18.77 KB, patch)
2021-12-08 14:37 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2021-12-08 11:59:24 PST 
This will allow SVGFilter and referenced SVGFilter to be applied in GPUProcess.
Comment 1 Said Abou-Hallawa 2021-12-08 12:17:55 PST 
Created attachment 446409 [details]
Patch
Comment 2 Wenson Hsieh 2021-12-08 12:28:15 PST 
Comment on attachment 446409 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446409&action=review

> Source/WebKit/Platform/IPC/FilterReference.h:334
> +    auto expressionReference = WTF::map(filter.expression(), [&indecies] (auto&& term) -> ExpressionReferenceTerm {

Nit - sp. indecies => indicies

> Source/WebKit/Platform/IPC/FilterReference.h:383
> +    WebCore::SVGFilterExpression expression;

Nit - maybe reserveInitialCapacity here?
Comment 3 Said Abou-Hallawa 2021-12-08 12:39:31 PST 
Created attachment 446410 [details]
Patch
Comment 4 Said Abou-Hallawa 2021-12-08 14:37:46 PST 
Created attachment 446422 [details]
Patch
Comment 5 EWS 2021-12-08 16:37:40 PST 
Committed r286753 (244996@main): <https://commits.webkit.org/244996@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446422 [details].
Comment 6 Radar WebKit Bug Importer 2021-12-08 16:38:25 PST 
<rdar://problem/86240715>