Fix consistency issues with localized strings, and regenerate localizable.strings

[David Kilzer (:ddkilzer)]

Fix consistency issues with localized strings and regenerate localizable.strings.

[David Kilzer (:ddkilzer)]

Created attachment 443138 [details]
Patch v1

[Devin Rousso]

Comment on attachment 443138 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=443138&action=review

> Source/WebCore/en.lproj/Localizable.strings:38
> +"%@ Easy (text track)" = "%@ Easy Reader";

this should actually probably be fixed in the corresponding code 😅

[David Kilzer (:ddkilzer)]

Comment on attachment 443138 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=443138&action=review

>> Source/WebCore/en.lproj/Localizable.strings:38
>> +"%@ Easy (text track)" = "%@ Easy Reader";
> 
> this should actually probably be fixed in the corresponding code 😅

Ah, I wasn't sure which way to go.  I will change the code to match the format string.  Thanks!

[David Kilzer (:ddkilzer)]

Comment on attachment 443138 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=443138&action=review

> Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm:280
> -    return [NSString localizedStringWithFormat:WEB_UI_NSSTRING(@"Use no more than %d character(s)", @"Validation message for form control elements with a value shorter than maximum allowed length"), maxLength];
> +    return formatLocalizedString(WEB_UI_CFSTRING("Use no more than %d character(s)", "Validation message for form control elements with a value shorter than maximum allowed length"), maxLength);

This caused a regression, so I'm going to remove it from this patch.  (It will appear in a follow-up patch, though.)

[David Kilzer (:ddkilzer)]

Created attachment 443143 [details]
Patch v2

[David Kilzer (:ddkilzer)]

Comment on attachment 443143 [details]
Patch v2

Thanks Megan!

[EWS]

Committed r285234 (243855@main): <https://commits.webkit.org/243855@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443143 [details].

[Radar WebKit Bug Importer]

<rdar://problem/84993811>