Bug 232462 - Remove code inside ENABLE(NETSCAPE_PLUGIN_API)
Summary: Remove code inside ENABLE(NETSCAPE_PLUGIN_API)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks: 232642 237555
  Show dependency tree / graph
 
Reported: 2021-10-28 16:28 PDT by Alex Christensen
Modified: 2022-03-07 14:08 PST (History)
17 users (show)

See Also:

Attachments
Patch (1.58 MB, patch)
2021-10-28 16:30 PDT, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (1.58 MB, patch)
2021-10-28 17:59 PDT, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (1.59 MB, patch)
2021-10-28 20:44 PDT, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-10-28 16:28:22 PDT 
Remove code inside ENABLE(NETSCAPE_PLUGIN_API)
Comment 1 Alex Christensen 2021-10-28 16:30:00 PDT 
Created attachment 442764 [details]
Patch
Comment 2 Alex Christensen 2021-10-28 17:59:35 PDT 
Created attachment 442769 [details]
Patch
Comment 3 Anders Carlsson 2021-10-28 19:27:35 PDT 
Comment on attachment 442769 [details]
Patch

I have to say I'm a little sad I didn't get to pull the plug(-ins), but at least I can r=me doing so.
Comment 4 Alex Christensen 2021-10-28 20:44:15 PDT 
Created attachment 442777 [details]
Patch
Comment 5 Alex Christensen 2021-10-28 22:44:56 PDT 
iOS needs a clean build after this change.
Comment 6 Yusuke Suzuki 2021-10-29 00:39:00 PDT 
I'm pretty happy that we can remove NPAPI support!!!
Now, super hacky RuntimeArray thing (runtime_array.cpp) is only used by Objective-C bridge.
Comment 7 Alex Christensen 2021-10-29 13:33:34 PDT 
r285047
Comment 8 Brent Fulgham 2021-10-29 14:09:33 PDT 
I love this patch so much!
Comment 9 Alex Christensen 2021-10-29 14:11:11 PDT 
r285051
Comment 10 Alex Christensen 2021-10-29 14:15:54 PDT 
r285052
Comment 11 Alex Christensen 2021-10-29 15:21:32 PDT 
r285058
Comment 12 Alex Christensen 2021-10-29 16:06:38 PDT 
Internal commit 2e4c44c95333771d6b86b5ac3f93cc5edb845ac2 was also necessary to fix the internal build.
Comment 13 Brent Fulgham 2021-11-12 10:18:43 PST 
<rdar://problem/84566739>