NEW 233483
check-webkit-style: regenerate localized strings when LocalizedStrings source files change 
https://bugs.webkit.org/show_bug.cgi?id=233483
Summary check-webkit-style: regenerate localized strings when LocalizedStrings source...
David Kilzer (:ddkilzer)
Reported 2021-11-24 15:30:46 PST
The webkit-patch script should regenerate localized strings when LocalizedStrings*.* source files change, and exit with an error if the Source/WebCore/en.lproj/Localizable.strings contains local changes (that didn't exist before). It's too easy to make localized string changes and forget to run Tools/Scripts/update-webkit-localizable-strings.
Attachments
Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2021-11-28 17:59:45 PST
should this be part of style checker? Webkit-patch changes would only help people who use webkit-patch.
Jonathan Bedard
Comment 2 2021-11-29 08:02:48 PST
webkit-patch invokes check-webkit-style (as will git-webkit), that's the right place to do this sort of thing.
David Kilzer (:ddkilzer)
Comment 3 2021-12-01 02:20:15 PST
My thinking was that knowledge of the changed files in the patch being uploaded would be needed in order to make a decision about whether this check needs to be done, and webkit-patch would have that (not check-WebKit-style). For example, if LocalizedStrings.cpp or LocalizedStringsCocoa.mm changed, then this should be checked, but otherwise it should not (to save time). I guess the actual code to do the checking could be in check-webkit-style, and the logic about whether to run the checker could be in webkit-patch, though.
Jonathan Bedard
Comment 4 2021-12-01 06:45:27 PST
(In reply to David Kilzer (:ddkilzer) from comment #3) > My thinking was that knowledge of the changed files in the patch being > uploaded would be needed in order to make a decision about whether this > check needs to be done, and webkit-patch would have that (not > check-WebKit-style). > > For example, if LocalizedStrings.cpp or LocalizedStringsCocoa.mm changed, > then this should be checked, but otherwise it should not (to save time). > > I guess the actual code to do the checking could be in check-webkit-style, > and the logic about whether to run the checker could be in webkit-patch, > though. check-webkit-style actually owns the knowledge of the changed files, since it only operates on the blocks of code a user is changing
Radar WebKit Bug Importer
Comment 5 2021-12-01 15:31:23 PST
<rdar://problem/85942550>
Note You need to log in before you can comment on or make changes to this bug.