Bug 232288 - Don't run ImageDiff a second time to generate diff images
Summary: Don't run ImageDiff a second time to generate diff images
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on: 232225
Blocks: 232294
  Show dependency tree / graph
 
Reported: 2021-10-25 17:28 PDT by Simon Fraser (smfr)
Modified: 2021-10-26 08:05 PDT (History)
7 users (show)

See Also:

Attachments
Patch (17.63 KB, patch)
2021-10-25 17:32 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (19.99 KB, patch)
2021-10-25 19:51 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (21.52 KB, patch)
2021-10-25 20:21 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-10-25 17:28:55 PDT 
Don't run ImageDiff a second time to generate diff images
Comment 1 Simon Fraser (smfr) 2021-10-25 17:32:09 PDT 
Created attachment 442441 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-10-25 19:51:16 PDT 
Created attachment 442456 [details]
Patch
Comment 3 Simon Fraser (smfr) 2021-10-25 20:21:34 PDT 
Created attachment 442459 [details]
Patch
Comment 4 Martin Robinson 2021-10-26 01:38:56 PDT 
Comment on attachment 442459 [details]
Patch

This is great and hopefully it speeds up tests a bit.
Comment 5 EWS 2021-10-26 08:04:20 PDT 
Committed r284866 (243543@main): <https://commits.webkit.org/243543@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442459 [details].
Comment 6 Radar WebKit Bug Importer 2021-10-26 08:05:21 PDT 
<rdar://problem/84663717>