Bug 232294 - Have ImageDiff print the diff image when any pixel is different
Summary: Have ImageDiff print the diff image when any pixel is different
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on: 232225 232288
Blocks:
  Show dependency tree / graph
 
Reported: 2021-10-25 20:47 PDT by Simon Fraser (smfr)
Modified: 2021-10-26 08:56 PDT (History)
5 users (show)

See Also:

Attachments
Patch (12.83 KB, patch)
2021-10-25 20:53 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-10-25 20:47:59 PDT 
Have ImageDiff print the diff image when any pixel is different
Comment 1 Simon Fraser (smfr) 2021-10-25 20:53:36 PDT 
Created attachment 442460 [details]
Patch
Comment 2 Martin Robinson 2021-10-26 02:14:41 PDT 
Comment on attachment 442460 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442460&action=review

I like where this is heading.

> Tools/Scripts/webkitpy/port/image_diff.py:133
> +        if diff_output:

I wonder if this should print some sort of warning is there is no diff_output?
Comment 3 EWS 2021-10-26 08:55:56 PDT 
Committed r284870 (243547@main): <https://commits.webkit.org/243547@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442460 [details].
Comment 4 Radar WebKit Bug Importer 2021-10-26 08:56:21 PDT 
<rdar://problem/84665305>