WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
232225
The script should decide when an image diff passes, not ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=232225
Summary
The script should decide when an image diff passes, not ImageDiff
Simon Fraser (smfr)
Reported
2021-10-24 21:31:21 PDT
Currently the ImageDiff binary determines when an image diff passes (diff is less than the tolerance), but it makes more sense for webkitpy to make that decision.
Attachments
Patch
(8.02 KB, patch)
2021-10-25 21:21 PDT
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2021-10-25 21:21:32 PDT
Created
attachment 442462
[details]
Patch
Simon Fraser (smfr)
Comment 2
2021-10-25 22:53:26 PDT
Comment on
attachment 442462
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=442462&action=review
> Tools/ChangeLog:3 > + The script should decide when an image diff cases, not ImageDiff
passes, not cases
Martin Robinson
Comment 3
2021-10-26 04:23:18 PDT
Comment on
attachment 442462
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=442462&action=review
This is a nice change.
> Tools/ImageDiff/ImageDiff.cpp:71 > + fprintf(stdout, "diff: %01.8f%%\n", differenceData.percentageDifference);
This is a nice simplification.
> Tools/Scripts/webkitpy/port/image_diff.py:137 > + return ImageDiffResult(passed=False, diff_image=None, difference=0, tolerance=self._tolerance, error_string=err_str or "Failed to match ImageDiff output %s" % diff_output)
I think using "Failed to match ImageDiff output {}".format(diff_output) would be better for future-proofing this code against changes to Python.
EWS
Comment 4
2021-10-26 10:39:26 PDT
Committed
r284878
(
243555@main
): <
https://commits.webkit.org/243555@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 442462
[details]
.
Radar WebKit Bug Importer
Comment 5
2021-10-26 10:40:21 PDT
<
rdar://problem/84670441
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug