Bug 231505 – Error the encoder in case we cannot create a RemoteVideoSample

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Error the encoder in case we cannot create a RemoteVideoSample

[youenn fablet]

<rdar://83975229>

[youenn fablet]

Created attachment 440767 [details]
Patch

[Eric Carlson]

Comment on attachment 440767 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440767&action=review

> Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:451
> +        if (!sample)
> +            return WEBRTC_VIDEO_CODEC_ERROR;

It might be worth logging this error too.

[youenn fablet]

Created attachment 440908 [details]
Patch for landing

[EWS]

Committed r283975 (242821@main): <https://commits.webkit.org/242821@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440908 [details].

[Alexey Proskuryakov]

*** Bug 232006 has been marked as a duplicate of this bug. ***

[Sam Sneddon [:gsnedders]]

*** Bug 232381 has been marked as a duplicate of this bug. ***

[Sam Sneddon [:gsnedders]]

*** Bug 232416 has been marked as a duplicate of this bug. ***

[youenn fablet]

*** Bug 232445 has been marked as a duplicate of this bug. ***

[Sam Sneddon [:gsnedders]]

*** Bug 232490 has been marked as a duplicate of this bug. ***

[ARUN GANESHAN]

HI team whats the update about this issues . What release will it be merged ?

[Eric]

OMG.
How do you do QA at Apple? 
In times of Covid, you've just ruined WebRTC H264 on Safari?
And it went all the way to iOS 15.1 "stable"?

Now we have to tell ALL our clients NOT to use Apple products! Well done.

[P Pramod]

It would help to get an update on the plan to address this issue?

[Dag-Inge Aas]

There was an update here: https://bugs.webkit.org/show_bug.cgi?id=232006#c9

I can confirm this is fixed in iOS 15.2 Public Beta.

two workaround:

1. Add this description to offer&answer sdp: "urn:3gpp:video-orientation", it will not cause page crash.
2. Use canvas.captureStream to capture a new video track from getUserMedia. Then, publish canvas track will not cause page crash.

[Shanker Pulugam]

Hi Webkit team,

Tried second workaround, used canvas captureStream from getUserMedia and publish canvas track but still crashes.
Can you please provide a working sample or any other way to fix the issue.

I'm not form webkit team.

The second workround works for our product.

You can try this sample to make a call on iOS 15.1: https://sdk-web-1252463788.cos.ap-hongkong.myqcloud.com/trtc/webrtc/test/rychou-test/addTransceiver/subscribe/index.html

This sample use canvas.captureStream and H.264 codec.

BTW, there is anothor workaround: use VP8 codec, do not use H.264

[Alexey Proskuryakov]

*** Bug 233038 has been marked as a duplicate of this bug. ***