Error the encoder in case we cannot create a RemoteVideoSample
Created attachment 440767 [details]
Comment on attachment 440767 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=440767&action=review
> + if (!sample)
> + return WEBRTC_VIDEO_CODEC_ERROR;
It might be worth logging this error too.
Created attachment 440908 [details]
Patch for landing
Committed r283975 (242821@main): <https://commits.webkit.org/242821@main>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 440908 [details].
*** Bug 232006 has been marked as a duplicate of this bug. ***
*** Bug 232381 has been marked as a duplicate of this bug. ***
*** Bug 232416 has been marked as a duplicate of this bug. ***
*** Bug 232445 has been marked as a duplicate of this bug. ***
*** Bug 232490 has been marked as a duplicate of this bug. ***
HI team whats the update about this issues . What release will it be merged ?
How do you do QA at Apple?
In times of Covid, you've just ruined WebRTC H264 on Safari?
And it went all the way to iOS 15.1 "stable"?
Now we have to tell ALL our clients NOT to use Apple products! Well done.
It would help to get an update on the plan to address this issue?
There was an update here: https://bugs.webkit.org/show_bug.cgi?id=232006#c9
I can confirm this is fixed in iOS 15.2 Public Beta.
1. Add this description to offer&answer sdp: "urn:3gpp:video-orientation", it will not cause page crash.
2. Use canvas.captureStream to capture a new video track from getUserMedia. Then, publish canvas track will not cause page crash.
Hi Webkit team,
Tried second workaround, used canvas captureStream from getUserMedia and publish canvas track but still crashes.
Can you please provide a working sample or any other way to fix the issue.
I'm not form webkit team.
The second workround works for our product.
You can try this sample to make a call on iOS 15.1: https://sdk-web-1252463788.cos.ap-hongkong.myqcloud.com/trtc/webrtc/test/rychou-test/addTransceiver/subscribe/index.html
This sample use canvas.captureStream and H.264 codec.
BTW, there is anothor workaround: use VP8 codec, do not use H.264
*** Bug 233038 has been marked as a duplicate of this bug. ***