Bug 230508 – Rename {checked,dynamic}_ns_cast<> to {checked,dynamic}_objc_cast<>

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[David Kilzer (:ddkilzer)]

Rename {checked,dynamic}_ns_cast<> to {checked,dynamic}_objc_cast<>.

In Bug 230406, Darin writes:
> Did you see my comment about dynamic_objc_cast? I think I prefer that name to dynamic_ns_cast.

[Radar WebKit Bug Importer]

<rdar://problem/83323145>

[David Kilzer (:ddkilzer)]

Created attachment 438729 [details]
Patch v1

[David Kilzer (:ddkilzer)]

Created attachment 438730 [details]
Patch v1 (showing changes in renamed files)

This is the same as "Patch v1" (Attachment #438729 [details]), but only shows changes in renamed files.

Much easier to review, but I'm not sure if EWS will handle it.

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #3)
> Created attachment 438730 [details]
> Patch v1 (showing changes in renamed files)
> 
> This is the same as "Patch v1" (Attachment #438729 [details]), but only
> shows changes in renamed files.
> 
> Much easier to review, but I'm not sure if EWS will handle it.

Hmmm...I guess svn-apply-patch will handle this just fine.  We should probably change svn-create-patch to use the pure git patch for renamed files to make them easier to review.

[David Kilzer (:ddkilzer)]

Review ping

[Brent Fulgham]

Comment on attachment 438730 [details]
Patch v1 (showing changes in renamed files)

r=me

[EWS]

Committed r282844 (241975@main): <https://commits.webkit.org/241975@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438730 [details].