Bug 229311 - [build.webkit.org] Port old unit test with the expected build steps to the new buildbot
Summary: [build.webkit.org] Port old unit test with the expected build steps to the ne...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-19 16:55 PDT by Carlos Alberto Lopez Perez
Modified: 2021-08-19 18:08 PDT (History)
5 users (show)

See Also:

Attachments
Patch (93.39 KB, patch)
2021-08-19 17:00 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Patch (93.36 KB, patch)
2021-08-19 17:07 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2021-08-19 16:55:41 PDT 
With the previous buildbot we had a very useful unit test that described all the expected steps for each builder, so each time you added or modified a builder you had also to add/modify the corresponding entry on the unit test, which served as an extra check that everything was going to work as expected.

With the migration to the new buildbot version this test was renamed and disabled because it was not compatible with the new buildbot version (see bug 219364 )

It would be a good idea to port this test to the new version
Comment 1 Carlos Alberto Lopez Perez 2021-08-19 17:00:58 PDT 
Created attachment 435923 [details]
Patch
Comment 2 Carlos Alberto Lopez Perez 2021-08-19 17:07:01 PDT 
Created attachment 435926 [details]
Patch
Comment 3 Aakash Jain 2021-08-19 17:25:19 PDT 
Comment on attachment 435926 [details]
Patch

Thanks for taking care of this.
We can also re-write https://github.com/WebKit/WebKit/blob/main/Tools/CISupport/ews-build/factories_unittest.py to make it similar to this one.
Comment 4 Carlos Alberto Lopez Perez 2021-08-19 17:39:04 PDT 
Comment on attachment 435926 [details]
Patch

Clearing flags on attachment: 435926

Committed r281286 (240711@main): <https://commits.webkit.org/240711@main>
Comment 5 Carlos Alberto Lopez Perez 2021-08-19 17:39:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Carlos Alberto Lopez Perez 2021-08-19 17:40:43 PDT 
(In reply to Aakash Jain from comment #3)
> Comment on attachment 435926 [details]
> Patch
> 
> Thanks for taking care of this.
> We can also re-write
> https://github.com/WebKit/WebKit/blob/main/Tools/CISupport/ews-build/
> factories_unittest.py to make it similar to this one.

you're welcome, thanks to you also for the quick review :)

yes, good idea!
Comment 7 Radar WebKit Bug Importer 2021-08-19 17:40:48 PDT 
<rdar://problem/82149509>
Comment 8 Carlos Alberto Lopez Perez 2021-08-19 18:08:00 PDT 
(In reply to Carlos Alberto Lopez Perez from comment #6)
> (In reply to Aakash Jain from comment #3)
> > Comment on attachment 435926 [details]
> > Patch
> > 
> > Thanks for taking care of this.
> > We can also re-write
> > https://github.com/WebKit/WebKit/blob/main/Tools/CISupport/ews-build/
> > factories_unittest.py to make it similar to this one.
> 
> you're welcome, thanks to you also for the quick review :)
> 
> yes, good idea!

Proposed patch adding that in bug 229319