Add a unit test for ews-build.webkit.org like the one added in bug 229311 for build.webkit.org
Created attachment 435931 [details] Patch
Comment on attachment 435931 [details] Patch This was fast! Should we delete all the existing unit-test in this file (since each queue/factory would now be covered by two separate unit-tests, and any change in a factory would require updating two similar unit-tests), or do you see any value in retaining them?
(In reply to Aakash Jain from comment #2) > Comment on attachment 435931 [details] > Patch > > This was fast! > > Should we delete all the existing unit-test in this file (since each > queue/factory would now be covered by two separate unit-tests, and any > change in a factory would require updating two similar unit-tests), or do > you see any value in retaining them? I have doubts regarding that so I took the more conservative approach. It seems the test functionality is kind of duplicated now, so I guess that deleting the previous ones makes sense to avoid having to maintain the two
Created attachment 435940 [details] Patch
Comment on attachment 435940 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435940&action=review > Tools/CISupport/ews-build/factories_unittest.py:32 > + "Style-EWS": [ Nit: we prefer using single quotes, but might be ok for now, we can change it later as well. > Tools/CISupport/ews-build/factories_unittest.py:572 > + self.assertListEqual(self.expected_steps[builder['name']], buildSteps, msg="Expected results don't match for builder %s" % builder['name']) Nit: "results" => "steps"
(In reply to Aakash Jain from comment #5) > Comment on attachment 435940 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=435940&action=review > > > Tools/CISupport/ews-build/factories_unittest.py:32 > > + "Style-EWS": [ > > Nit: we prefer using single quotes, but might be ok for now, we can change > it later as well. > > > Tools/CISupport/ews-build/factories_unittest.py:572 > > + self.assertListEqual(self.expected_steps[builder['name']], buildSteps, msg="Expected results don't match for builder %s" % builder['name']) > > Nit: "results" => "steps" Ok. Changing that here and also on the equivalent test for build.webkit.org for consistency
Committed r281322 (240739@main): <https://commits.webkit.org/240739@main>
<rdar://problem/82175147>