Bug 229312 – [build.webkit.org] GTK-Linux-64-bit-Release-Skip-Failing-Tests worker should run only layout tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Alberto Lopez Perez]

On bug 227744 a new tester was added, but this tester should only be running layout tests. It is not useful that this bots run other kind of tests like api tests, python tests or perl tests.

[Carlos Alberto Lopez Perez]

Created attachment 435930 [details]
Patch

[Aakash Jain]

Comment on attachment 435930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435930&action=review

> Tools/CISupport/build-webkit-org/factories.py:218
> +class TestLayoutFactory(Factory):

Nit: better to call it LayoutTestFactory (even though the naming might not be good earlier, we can improve it now)

[Aakash Jain]

Comment on attachment 435930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435930&action=review

> Tools/CISupport/build-webkit-org/factories.py:225
> +            self.addStep(RunDashboardTests())

Do you want to run dashboard tests on this queue?

[Carlos Alberto Lopez Perez]

(In reply to Aakash Jain from comment #2)
> Comment on attachment 435930 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=435930&action=review
> 
> > Tools/CISupport/build-webkit-org/factories.py:218
> > +class TestLayoutFactory(Factory):
> 
> Nit: better to call it LayoutTestFactory (even though the naming might not
> be good earlier, we can improve it now)

That would be inconsistent with the other factory naming.. all are named either "TestSomethingFactory" or "BuildAndTestSomethingFactory"

[Carlos Alberto Lopez Perez]

(In reply to Aakash Jain from comment #3)
> Comment on attachment 435930 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=435930&action=review
> 
> > Tools/CISupport/build-webkit-org/factories.py:225
> > +            self.addStep(RunDashboardTests())
> 
> Do you want to run dashboard tests on this queue?


I think we do, for consistency, as far as I can see the dashboard tests runner simply calls run-webkit-tests over other directory than LayoutTests. So they seem to me like some kind of specialized layout tests.

[Carlos Alberto Lopez Perez]

Committed r281327 (240744@main): <https://commits.webkit.org/240744@main>

[Radar WebKit Bug Importer]

<rdar://problem/82178321>

[Aakash Jain]

buildbot was restarted to pick up this change. Seems to be working, e.g.: https://build.webkit.org/#/builders/199/builds/951