Bug 229312 - [build.webkit.org] GTK-Linux-64-bit-Release-Skip-Failing-Tests worker should run only layout tests
Summary: [build.webkit.org] GTK-Linux-64-bit-Release-Skip-Failing-Tests worker should ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-19 17:13 PDT by Carlos Alberto Lopez Perez
Modified: 2021-08-26 10:39 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.07 KB, patch)
2021-08-19 17:43 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2021-08-19 17:13:31 PDT 
On bug 227744 a new tester was added, but this tester should only be running layout tests. It is not useful that this bots run other kind of tests like api tests, python tests or perl tests.
Comment 1 Carlos Alberto Lopez Perez 2021-08-19 17:43:45 PDT 
Created attachment 435930 [details]
Patch
Comment 2 Aakash Jain 2021-08-20 07:38:21 PDT 
Comment on attachment 435930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435930&action=review

> Tools/CISupport/build-webkit-org/factories.py:218
> +class TestLayoutFactory(Factory):

Nit: better to call it LayoutTestFactory (even though the naming might not be good earlier, we can improve it now)
Comment 3 Aakash Jain 2021-08-20 07:42:08 PDT 
Comment on attachment 435930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435930&action=review

> Tools/CISupport/build-webkit-org/factories.py:225
> +            self.addStep(RunDashboardTests())

Do you want to run dashboard tests on this queue?
Comment 4 Carlos Alberto Lopez Perez 2021-08-20 09:31:43 PDT 
(In reply to Aakash Jain from comment #2)
> Comment on attachment 435930 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=435930&action=review
> 
> > Tools/CISupport/build-webkit-org/factories.py:218
> > +class TestLayoutFactory(Factory):
> 
> Nit: better to call it LayoutTestFactory (even though the naming might not
> be good earlier, we can improve it now)

That would be inconsistent with the other factory naming.. all are named either "TestSomethingFactory" or "BuildAndTestSomethingFactory"
Comment 5 Carlos Alberto Lopez Perez 2021-08-20 09:53:54 PDT 
(In reply to Aakash Jain from comment #3)
> Comment on attachment 435930 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=435930&action=review
> 
> > Tools/CISupport/build-webkit-org/factories.py:225
> > +            self.addStep(RunDashboardTests())
> 
> Do you want to run dashboard tests on this queue?


I think we do, for consistency, as far as I can see the dashboard tests runner simply calls run-webkit-tests over other directory than LayoutTests. So they seem to me like some kind of specialized layout tests.
Comment 6 Carlos Alberto Lopez Perez 2021-08-20 11:25:38 PDT 
Committed r281327 (240744@main): <https://commits.webkit.org/240744@main>
Comment 7 Radar WebKit Bug Importer 2021-08-20 11:26:20 PDT 
<rdar://problem/82178321>
Comment 8 Aakash Jain 2021-08-26 10:39:47 PDT 
buildbot was restarted to pick up this change. Seems to be working, e.g.: https://build.webkit.org/#/builders/199/builds/951