Bug 227250 – Not all uses of AudioToolbox framework use soft linking

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jean-Yves Avenard [:jya]]

Noticed while working on bug 227205.

On iOS for some use of the AudioToolbox, soft-linking is used but not others.
Additionally, there are multiple definition of the macro to define some methods like AudioConverterNew where the macro to link it is used unnecessarily 4 times.

[Radar WebKit Bug Importer]

<rdar://problem/79606090>

[Jean-Yves Avenard [:jya]]

Created attachment 431956 [details]
Patch

[Jean-Yves Avenard [:jya]]

Depends on bug 227208 to build

[Eric Carlson]

Comment on attachment 431956 [details]
Patch

r=me once the bots are happy

[Jean-Yves Avenard [:jya]]

Created attachment 432043 [details]
Patch

[Jean-Yves Avenard [:jya]]

Created attachment 432047 [details]
Patch

rebase

[Jean-Yves Avenard [:jya]]

Created attachment 432102 [details]
Patch

fix compilation on iOS/tvOS

[Jean-Yves Avenard [:jya]]

Created attachment 432108 [details]
Patch

rebase

[Jean-Yves Avenard [:jya]]

Created attachment 432116 [details]
Patch

Fix iOS compilation

[Jean-Yves Avenard [:jya]]

Created attachment 432119 [details]
Patch

Fix tvOS compilation

[Eric Carlson]

Comment on attachment 432119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432119&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:39
> +// WTF_DECLARE_CF_TYPE_TRAIT(CMSampleBuffer);

This should be removed.

> Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:46
> +// WTF_DECLARE_CF_TYPE_TRAIT(CMSampleBuffer);

Ditto.

[Jean-Yves Avenard [:jya]]

Created attachment 432121 [details]
Patch

Apply comments

[Jean-Yves Avenard [:jya]]

Created attachment 432122 [details]
Patch

fix build #459

[EWS]

ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.

[Jean-Yves Avenard [:jya]]

Created attachment 432127 [details]
Patch

Fix changelog

[EWS]

Committed r279208 (239094@main): <https://commits.webkit.org/239094@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432127 [details].

[Ryan Haddad]

I reverted this in https://commits.webkit.org/239167@main because it broke the Windows build.

[Jean-Yves Avenard [:jya]]

Created attachment 432363 [details]
Patch

Re-ordered some definitions as they didn't exist on Windows

[EWS]

Committed r279322 (239198@main): <https://commits.webkit.org/239198@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432363 [details].

[WebKit Commit Bot]

Re-opened since this is blocked by bug 227434

[Jean-Yves Avenard [:jya]]

Created attachment 432365 [details]
Patch

Turned out, those non-existing symbols are in use on Windows

[Jean-Yves Avenard [:jya]]

Created attachment 432367 [details]
Patch

[Jean-Yves Avenard [:jya]]

Created attachment 432372 [details]
Patch

[Jean-Yves Avenard [:jya]]

Created attachment 432374 [details]
Patch

[EWS]

Committed r279335 (239204@main): <https://commits.webkit.org/239204@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432374 [details].