Bug 227381 - REGRESSION (r279208): Windows build failing with errors in CoreMediaSoftLink
Summary: REGRESSION (r279208): Windows build failing with errors in CoreMediaSoftLink
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-24 17:32 PDT by Ryan Haddad
Modified: 2021-06-25 10:13 PDT (History)
15 users (show)

See Also:

Attachments
Revert patch (291.03 KB, patch)
2021-06-25 09:19 PDT, Ryan Haddad 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (291.03 KB, patch)
2021-06-25 09:37 PDT, Ryan Haddad 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2021-06-24 17:32:26 PDT 
The Windows build was broken by https://trac.webkit.org/changeset/279208/webkit
C:\cygwin\home\buildbot\worker\win10-debug\build\Source\WebCore\PAL\pal\cf\CoreMediaSoftLink.cpp(203,1): error C2061: syntax error: identifier 'CMClockRef' [C:\cygwin\home\buildbot\worker\win10-debug\build\WebKitBuild\Debug\Source\WebCore\PAL\pal\PAL.vcxproj]
C:\cygwin\home\buildbot\worker\win10-debug\build\Source\WebCore\PAL\pal\cf\CoreMediaSoftLink.h(348,1): error C2061: syntax error: identifier 'CMClockRef' (compiling source file C:\cygwin\home\buildbot\worker\win10-debug\build\Source\WebCore\PAL\pal\avfoundation\MediaTimeAVFoundation.cpp) [C:\cygwin\home\buildbot\worker\win10-debug\build\WebKitBuild\Debug\Source\WebCore\PAL\pal\PAL.vcxproj]
https://build.webkit.org/#/builders/56/builds/3037/steps/8/logs/stdio
Comment 1 Ryan Haddad 2021-06-25 09:19:41 PDT 
Created attachment 432279 [details]
Revert patch
Comment 2 Ryan Haddad 2021-06-25 09:37:08 PDT 
Created attachment 432281 [details]
Patch
Comment 3 EWS 2021-06-25 10:12:19 PDT 
Committed r279288 (239167@main): <https://commits.webkit.org/239167@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432281 [details].
Comment 4 Radar WebKit Bug Importer 2021-06-25 10:13:19 PDT 
<rdar://problem/79784193>