Bug 227435 - Used of non-existing symbols on Windows
Summary: Used of non-existing symbols on Windows
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-27 22:31 PDT by Jean-Yves Avenard [:jya]
Modified: 2023-10-14 04:15 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2021-06-27 22:31:52 PDT 
Seen in bug 227250

When I removed some symbols from PAL/CoreMediaSoftLink.h as they aren't defined on Windows ; it caused a compilation error on the Windows bots:

:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(265,38): error C2065: 'kCMTextMarkupAttribute_ForegroundColorARGB': undeclared identifier [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(277,38): error C2065: 'kCMTextMarkupAttribute_BackgroundColorARGB': undeclared identifier [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKi tBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(289,38): error C2065: 'kCMTextMarkupAttribute_CharacterBackgroundColorARGB': undeclared identifier [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(515,42): error C3861: 'CMFormatDescriptionGetExtensions': identifier not found [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(519,121): error C2065: 'kCMFormatDescriptionExtension_SampleDescriptionExtensionAtoms': undeclared identifier [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Sour ce\WebCore\WebCore.vcxproj]
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(562,23): error C3861: 'CMSampleBufferGetSampleTimingInfo': identifier not found [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(570,36): error C3861: 'CMSampleBufferGetDataBuffer': identifier not found [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(571,27): error C3861: 'CMBlockBufferGetDataLength': identifier not found [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\home\buildbot\worker\Windows-EWS\build\ Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(578,5): error C3861: 'CMBlockBufferCopyDataBytes': identifier not found [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(582,25): error C3861: 'CMSampleBufferGetFormatDescription': identifier not found [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]

So they are used in code compiled on Windows, but those symbols can't be resolved which would lead to either an assert or a null deref at run time; so either we shouldn't use them at all or they should be added to the Framework (unlikely)
Comment 1 Radar WebKit Bug Importer 2021-06-27 22:32:19 PDT 
<rdar://problem/79849694>
Comment 2 Ahmad Saleem 2023-10-14 03:15:06 PDT 
@Fuji - is this applicable for win-cairo build?

From below, it seems to look like 'AppleWin', I think we can mark this as "RESOLVED CONFIGURATION CHANGED".