Bug 224716 - REGRESSION(r275655): Introduced many debug build warnings
Summary: REGRESSION(r275655): Introduced many debug build warnings
Status: RESOLVED DUPLICATE of bug 224335
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-17 03:45 PDT by Philippe Normand
Modified: 2021-04-19 00:39 PDT (History)
2 users (show)

See Also:

Attachments
Patch (11.44 KB, patch)
2021-04-17 03:58 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
Patch (13.82 KB, patch)
2021-04-17 04:11 PDT, Philippe Normand 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2021-04-17 03:45:02 PDT 
https://bugs.webkit.org/show_bug.cgi?id=224269#c4
Comment 1 Philippe Normand 2021-04-17 03:58:36 PDT 
Created attachment 426330 [details]
Patch
Comment 2 Philippe Normand 2021-04-17 04:11:57 PDT 
Created attachment 426331 [details]
Patch
Comment 3 Darin Adler 2021-04-17 17:49:01 PDT 
Comment on attachment 426331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426331&action=review

> Source/WebKit/ChangeLog:8
> +        PRIu64 is the most portable format specifier for unsigned long long.

This comment is inaccurate.

PRIu64 is the correct format specifier for uint64_t.

If the type is actually "unsigned long long" then PRIu64 is not correct.
Comment 4 Kimmo Kinnunen 2021-04-18 23:16:26 PDT 
I tried to fix these in bug 224335 already on 2021-04-12 (or did I fail landing or was it reverted)?
Comment 5 Kimmo Kinnunen 2021-04-18 23:24:32 PDT 
Yep, I failed to land it but Darin then landed it.
Philippe, Darin, sorry for the trouble..
Comment 6 Philippe Normand 2021-04-19 00:38:48 PDT 

*** This bug has been marked as a duplicate of bug 224335 ***