Bug 224335 - Unhandled IPC messages should use correct format with the decoder.destinationID() ASSERT message
Summary: Unhandled IPC messages should use correct format with the decoder.destination...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
: 224716 (view as bug list)
Depends on: 224269
Blocks:
  Show dependency tree / graph
 
Reported: 2021-04-08 12:06 PDT by Kimmo Kinnunen
Modified: 2021-04-19 00:38 PDT (History)
6 users (show)

See Also:

Attachments
Patch (14.30 KB, patch)
2021-04-12 00:12 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-04-08 12:06:13 PDT 
Comment # 4 on bug 224269 from Darin Adler
Comment on attachment 425357 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425357&action=review

> Source/WebKit/Scripts/webkit/messages.py:951
> +            result.append('    ASSERT_NOT_REACHED_WITH_MESSAGE("Unhandled stream message %s to %llu", description(decoder.messageName()), decoder.destinationID());\n')

These are not quite right. Nothing guarantees that destinationID() is an unsigned long long. We need to use PRIu64 (not sure I got that right) instead of %llu.
Comment 1 Kimmo Kinnunen 2021-04-12 00:12:57 PDT 
Created attachment 425720 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-04-15 12:07:42 PDT 
<rdar://problem/76716374>
Comment 3 EWS 2021-04-17 21:47:57 PDT 
Committed r276221 (236703@main): <https://commits.webkit.org/236703@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425720 [details].
Comment 4 Philippe Normand 2021-04-19 00:38:48 PDT 
*** Bug 224716 has been marked as a duplicate of this bug. ***