RESOLVED FIXED 224269
Difficult to understand which IPC message caused an ASSERT due to being not handled 
https://bugs.webkit.org/show_bug.cgi?id=224269
Summary Difficult to understand which IPC message caused an ASSERT due to being not h...
Kimmo Kinnunen
Reported 2021-04-06 23:10:25 PDT
Difficult to understand which IPC message caused an ASSERT due to being not handled The assert should print the message name
Attachments
Patch (12.57 KB, patch)
2021-04-06 23:12 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2021-04-06 23:12:12 PDT
Created attachment 425357 [details] Patch
EWS
Comment 2 2021-04-08 01:58:29 PDT
Committed r275655: <https://commits.webkit.org/r275655> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425357 [details].
Radar WebKit Bug Importer
Comment 3 2021-04-08 01:59:14 PDT
<rdar://problem/76389887>
Darin Adler
Comment 4 2021-04-08 10:39:36 PDT
Comment on attachment 425357 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425357&action=review > Source/WebKit/Scripts/webkit/messages.py:951 > + result.append(' ASSERT_NOT_REACHED_WITH_MESSAGE("Unhandled stream message %s to %llu", description(decoder.messageName()), decoder.destinationID());\n') These are not quite right. Nothing guarantees that destinationID() is an unsigned long long. We need to use PRIu64 (not sure I got that right) instead of %llu.
Philippe Normand
Comment 5 2021-04-11 03:03:46 PDT
PRIu64 is the right specifier here indeed.
Note You need to log in before you can comment on or make changes to this bug.