Bug 224139 – [GPUP] Implement SourceBufferPrivateRemote::bufferFull()

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Peng Liu]

The patch for bug 224136 will enable the code using SourceBufferPrivate::bufferFull() for Cocoa ports. We need to add the function implementation in SourceBufferPrivateRemote in order to support the "Media in GPU Process" scenario.

[Radar WebKit Bug Importer]

<rdar://problem/76280442>

[Peng Liu]

Created attachment 426307 [details]
WIP patch

[Peng Liu]

Created attachment 426484 [details]
Patch

[Peng Liu]

Created attachment 426487 [details]
Fix build failures

[Eric Carlson]

Comment on attachment 426484 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426484&action=review

> Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:212
> +    MediaPlayerFactorySupport::callRegisterMediaEngine(MockMediaPlayerMediaSource::registerMediaEngine);

It would probably be better to have this in media-specific code. Maybe in the RemoteMediaPlayerManagerProxy constructor?

> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:689
> +    if (m_remoteEngineIdentifier == MediaPlayerEnums::MediaEngineIdentifier::AVFoundationMSE || m_remoteEngineIdentifier == MediaPlayerEnums::MediaEngineIdentifier::MockMSE) {

Nit: something like an "isMSE()" method that checks the identifier would be cleaner and more future proof.

[Eric Carlson]

Comment on attachment 426487 [details]
Fix build failures

r=me once the bots are happy

[Peng Liu]

I am going to fix the test issues in bug 225367.

[Peng Liu]

Created attachment 427710 [details]
[fast-cq] Patch

[EWS]

Committed r277003 (237323@main): <https://commits.webkit.org/237323@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427710 [details].