Bug 224139 - [GPUP] Implement SourceBufferPrivateRemote::bufferFull()
Summary: [GPUP] Implement SourceBufferPrivateRemote::bufferFull()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on: 224136 224848 224891
Blocks:
  Show dependency treegraph
 
Reported: 2021-04-02 16:21 PDT by Peng Liu
Modified: 2021-05-04 22:41 PDT (History)
7 users (show)

See Also:


Attachments
WIP patch (13.43 KB, patch)
2021-04-16 18:30 PDT, Peng Liu
no flags Details | Formatted Diff | Diff
Patch (28.61 KB, patch)
2021-04-19 15:50 PDT, Peng Liu
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Fix build failures (28.42 KB, patch)
2021-04-19 16:11 PDT, Peng Liu
no flags Details | Formatted Diff | Diff
[fast-cq] Patch (9.83 KB, patch)
2021-05-04 16:19 PDT, Peng Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2021-04-02 16:21:47 PDT
The patch for bug 224136 will enable the code using SourceBufferPrivate::bufferFull() for Cocoa ports. We need to add the function implementation in SourceBufferPrivateRemote in order to support the "Media in GPU Process" scenario.
Comment 1 Radar WebKit Bug Importer 2021-04-06 13:00:27 PDT
<rdar://problem/76280442>
Comment 2 Peng Liu 2021-04-16 18:30:48 PDT
Created attachment 426307 [details]
WIP patch
Comment 3 Peng Liu 2021-04-19 15:50:26 PDT
Created attachment 426484 [details]
Patch
Comment 4 Peng Liu 2021-04-19 16:11:16 PDT
Created attachment 426487 [details]
Fix build failures
Comment 5 Eric Carlson 2021-04-19 16:26:12 PDT
Comment on attachment 426484 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426484&action=review

> Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:212
> +    MediaPlayerFactorySupport::callRegisterMediaEngine(MockMediaPlayerMediaSource::registerMediaEngine);

It would probably be better to have this in media-specific code. Maybe in the RemoteMediaPlayerManagerProxy constructor?

> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:689
> +    if (m_remoteEngineIdentifier == MediaPlayerEnums::MediaEngineIdentifier::AVFoundationMSE || m_remoteEngineIdentifier == MediaPlayerEnums::MediaEngineIdentifier::MockMSE) {

Nit: something like an "isMSE()" method that checks the identifier would be cleaner and more future proof.
Comment 6 Eric Carlson 2021-04-19 16:26:35 PDT
Comment on attachment 426487 [details]
Fix build failures

r=me once the bots are happy
Comment 7 Peng Liu 2021-05-04 14:41:19 PDT
I am going to fix the test issues in bug 225367.
Comment 8 Peng Liu 2021-05-04 16:19:09 PDT
Created attachment 427710 [details]
[fast-cq] Patch
Comment 9 EWS 2021-05-04 22:41:40 PDT
Committed r277003 (237323@main): <https://commits.webkit.org/237323@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427710 [details].