Bug 224136 - Enable QuotaExceededError on non GSTREAMER platforms
Summary: Enable QuotaExceededError on non GSTREAMER platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks: 224139
  Show dependency tree / graph
 
Reported: 2021-04-02 15:30 PDT by Saam Barati
Modified: 2021-04-06 10:51 PDT (History)
13 users (show)

See Also:

Attachments
patch (1.87 KB, patch)
2021-04-02 15:35 PDT, Saam Barati 		jer.noble: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch for landing (3.46 KB, patch)
2021-04-02 18:09 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2021-04-02 15:30:27 PDT 
...
Comment 1 Saam Barati 2021-04-02 15:31:06 PDT 
<rdar://71219720>
Comment 2 Saam Barati 2021-04-02 15:35:57 PDT 
Created attachment 425061 [details]
patch
Comment 3 Saam Barati 2021-04-02 18:09:19 PDT 
Created attachment 425072 [details]
patch for landing
Comment 4 Brent Fulgham 2021-04-05 10:03:28 PDT 
Comment on attachment 425072 [details]
patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=425072&action=review

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:-500
> -#endif

Oh, wow! Did we audit other GSTREAMER-only code to make sure nothing else was missed?
Comment 5 Saam Barati 2021-04-05 11:19:29 PDT 
Comment on attachment 425072 [details]
patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=425072&action=review

>> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:-500
>> -#endif
> 
> Oh, wow! Did we audit other GSTREAMER-only code to make sure nothing else was missed?

I haven't. Probably best for someone who truly understands the media code to do this.

Also, this change isn't sufficient for media in gpu process. That'll be done by Peng in:
https://bugs.webkit.org/show_bug.cgi?id=224139
Comment 6 EWS 2021-04-05 18:06:27 PDT 
Committed r275466: <https://commits.webkit.org/r275466>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425072 [details].
Comment 7 Peng Liu 2021-04-06 10:51:20 PDT 
Comment on attachment 425072 [details]
patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=425072&action=review

>>> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:-500
>>> -#endif
>> 
>> Oh, wow! Did we audit other GSTREAMER-only code to make sure nothing else was missed?
> 
> I haven't. Probably best for someone who truly understands the media code to do this.
> 
> Also, this change isn't sufficient for media in gpu process. That'll be done by Peng in:
> https://bugs.webkit.org/show_bug.cgi?id=224139

By the way, the code is GStreamer port only because some sites did not work well if we enable the exception, and it was the only one case in the current MSE implementation as far as I know.