Bug 224891 - [GPUP] Refactor SourceBuffer::enqueuedSamplesForTrackID() for testing purposes
Summary: [GPUP] Refactor SourceBuffer::enqueuedSamplesForTrackID() for testing purposes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks: 224139
  Show dependency tree / graph
 
Reported: 2021-04-21 13:21 PDT by Peng Liu
Modified: 2021-04-22 17:49 PDT (History)
8 users (show)

See Also:

Attachments
Patch (30.08 KB, patch)
2021-04-21 13:35 PDT, Peng Liu 		eric.carlson: review+
Details | Formatted Diff | Diff
[fast-cq] Patch for landing (30.28 KB, patch)
2021-04-21 14:12 PDT, Peng Liu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2021-04-21 13:21:01 PDT 
[GPUP] Refactor SourceBuffer::enqueuedSamplesForTrackID() for testing purposes
Comment 1 Peng Liu 2021-04-21 13:35:25 PDT 
Created attachment 426739 [details]
Patch
Comment 2 Eric Carlson 2021-04-21 14:01:22 PDT 
Comment on attachment 426739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426739&action=review

> LayoutTests/media/media-source/media-source-append-presentation-durations.html:56
> +        enqueuedSamples = await internals.enqueuedSamplesForTrackID(sourceBuffer, 1);

Nit: `const enqueuedSamples = ...`

> LayoutTests/media/media-source/media-source-erase-after-last-append.html:50
> +            enqueuedSamples = await internals.enqueuedSamplesForTrackID(sourceBuffer, 1);

Ditto

> LayoutTests/media/media-source/media-source-first-append-not-starting-at-zero.html:45
> +        enqueuedSamples = await internals.enqueuedSamplesForTrackID(sourceBuffer, 1);

Nit: `let enqueuedSamples = ...`

> LayoutTests/media/media-source/media-source-remove-b-frame.html:45
> +        enqueuedSamples = await internals.enqueuedSamplesForTrackID(sourceBuffer, 1);

Ditto
Comment 3 Peng Liu 2021-04-21 14:12:37 PDT 
Created attachment 426744 [details]
[fast-cq] Patch for landing
Comment 4 Peng Liu 2021-04-21 14:13:38 PDT 
Comment on attachment 426739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426739&action=review

>> LayoutTests/media/media-source/media-source-append-presentation-durations.html:56
>> +        enqueuedSamples = await internals.enqueuedSamplesForTrackID(sourceBuffer, 1);
> 
> Nit: `const enqueuedSamples = ...`

Fixed this and all others. Thanks!
Comment 5 EWS 2021-04-21 18:28:46 PDT 
Committed r276414 (236879@main): <https://commits.webkit.org/236879@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426744 [details].
Comment 6 Radar WebKit Bug Importer 2021-04-22 17:49:42 PDT 
<rdar://problem/77047943>