RESOLVED FIXED 224891
[GPUP] Refactor SourceBuffer::enqueuedSamplesForTrackID() for testing purposes 
https://bugs.webkit.org/show_bug.cgi?id=224891
Summary [GPUP] Refactor SourceBuffer::enqueuedSamplesForTrackID() for testing purposes
Peng Liu
Reported 2021-04-21 13:21:01 PDT
[GPUP] Refactor SourceBuffer::enqueuedSamplesForTrackID() for testing purposes
Attachments
Patch (30.08 KB, patch)
2021-04-21 13:35 PDT, Peng Liu 		eric.carlson: review+
DetailsFormatted DiffDiff
[fast-cq] Patch for landing (30.28 KB, patch)
2021-04-21 14:12 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peng Liu
Comment 1 2021-04-21 13:35:25 PDT
Created attachment 426739 [details] Patch
Eric Carlson
Comment 2 2021-04-21 14:01:22 PDT
Comment on attachment 426739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426739&action=review > LayoutTests/media/media-source/media-source-append-presentation-durations.html:56 > + enqueuedSamples = await internals.enqueuedSamplesForTrackID(sourceBuffer, 1); Nit: `const enqueuedSamples = ...` > LayoutTests/media/media-source/media-source-erase-after-last-append.html:50 > + enqueuedSamples = await internals.enqueuedSamplesForTrackID(sourceBuffer, 1); Ditto > LayoutTests/media/media-source/media-source-first-append-not-starting-at-zero.html:45 > + enqueuedSamples = await internals.enqueuedSamplesForTrackID(sourceBuffer, 1); Nit: `let enqueuedSamples = ...` > LayoutTests/media/media-source/media-source-remove-b-frame.html:45 > + enqueuedSamples = await internals.enqueuedSamplesForTrackID(sourceBuffer, 1); Ditto
Peng Liu
Comment 3 2021-04-21 14:12:37 PDT
Created attachment 426744 [details] [fast-cq] Patch for landing
Peng Liu
Comment 4 2021-04-21 14:13:38 PDT
Comment on attachment 426739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426739&action=review >> LayoutTests/media/media-source/media-source-append-presentation-durations.html:56 >> + enqueuedSamples = await internals.enqueuedSamplesForTrackID(sourceBuffer, 1); > > Nit: `const enqueuedSamples = ...` Fixed this and all others. Thanks!
EWS
Comment 5 2021-04-21 18:28:46 PDT
Committed r276414 (236879@main): <https://commits.webkit.org/236879@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426744 [details].
Radar WebKit Bug Importer
Comment 6 2021-04-22 17:49:42 PDT
<rdar://problem/77047943>
Note You need to log in before you can comment on or make changes to this bug.