Newly imported WPT tests are failing: imported/w3c/web-platform-tests/css/css-flexbox/flexbox-flex-basis-content-001a.html imported/w3c/web-platform-tests/css/css-flexbox/flexbox-flex-basis-content-001b.html imported/w3c/web-platform-tests/css/css-flexbox/flexbox-flex-basis-content-002a.html imported/w3c/web-platform-tests/css/css-flexbox/flexbox-flex-basis-content-002b.html imported/w3c/web-platform-tests/css/css-flexbox/flexbox-flex-basis-content-003a.html imported/w3c/web-platform-tests/css/css-flexbox/flexbox-flex-basis-content-004a.html
It is quite possible aspect-ratio like this one depend on this support: css/css-sizing/aspect-ratio/flex-aspect-ratio-021.html
<rdar://problem/74279369>
Also some other tests that depend on this: imported/w3c/web-platform-tests/css/css-flexbox/parsing/flex-basis-computed.html imported/w3c/web-platform-tests/css/css-flexbox/parsing/flex-basis-valid.html imported/w3c/web-platform-tests/css/css-flexbox/parsing/flex-shorthand.html they currently have FAIL expectations for those content|fit-content|min-content|max-content values
Created attachment 441583 [details] Patch
Created attachment 441602 [details] Patch
Comment on attachment 441602 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441602&action=review r=me > Source/WebCore/ChangeLog:10 > + equivalent to the max-content size but it has some adjustments for aspect ratios, Is this patch implementing those aspect-ratio adjustments ? Otherwise, perhaps we should clarify it in the ChangeLog.
Comment on attachment 441602 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441602&action=review Thanks for the review! >> Source/WebCore/ChangeLog:10 >> + equivalent to the max-content size but it has some adjustments for aspect ratios, > > Is this patch implementing those aspect-ratio adjustments ? Otherwise, perhaps we should clarify it in the ChangeLog. Yes, those adjustments are implemented in computeFlexBaseSizeForChild(). They were previously applied only to 'auto'. Now they apply also to 'content'.
(In reply to Sergio Villar Senin from comment #7) > Comment on attachment 441602 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=441602&action=review > > Thanks for the review! > > >> Source/WebCore/ChangeLog:10 > >> + equivalent to the max-content size but it has some adjustments for aspect ratios, > > > > Is this patch implementing those aspect-ratio adjustments ? Otherwise, perhaps we should clarify it in the ChangeLog. > > Yes, those adjustments are implemented in computeFlexBaseSizeForChild(). > They were previously applied only to 'auto'. Now they apply also to > 'content'. I meant, the adjustments were implemented long time ago. It's just that we were applying to those cases were flex-basis is auto. Now they apply also to the cases were flex-basis is content. More precisely both cases are the same because the *used* value for flex basis is 'content' when 'flex-basis:auto' and the main size of the flex item is also 'auto'.
Committed r284440 (243202@main): <https://commits.webkit.org/243202@main>
Reverted in https://trac.webkit.org/changeset/285045/webkit Because the relying change causes 100% CPU usage in Twitter
After the revert, imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-021.html imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-022.html Started constantly failing. Tracking in https://bugs.webkit.org/show_bug.cgi?id=232518.
Created attachment 443937 [details] Patch
Comment on attachment 443937 [details] Patch r=me (as long as all the bots finish green)
Committed r285709 (244168@main): <https://commits.webkit.org/244168@main>