Bug 136754 - [css-flexbox] Failing some official flexbox tests
Summary: [css-flexbox] Failing some official flexbox tests
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-09-11 13:25 PDT by Dean Jackson
Modified: 2020-04-15 12:03 PDT (History)
9 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2014-09-11 13:25:34 PDT
While unprefixing flexbox, I imported a bunch of official W3C tests. There are some failures. Some are minor reference differences, but others are significant differences. I have not checked if the test or the implementation is wrong. I did a random sample of failures and WebKit matches Blink, so I don't think these are showstoppers.

All found in css3/flexbox/csswg

css-box-justify-content.html
css-flexbox-img-expand-evenly.html
css-flexbox-row.html
css-flexbox-test1.html
flex-align-items-center.html
flex-flexitem-percentage-prescation.html
flex-items-flexibility.html
flex-lines/multi-line-wrap-reverse-column-reverse.html
flex-lines/multi-line-wrap-with-column-reverse.html
flex-margin-no-collapse.html
flexbox-flex-wrap-flexing.html
flexbox_flex-0-0-0.html
flexbox_flex-0-1-0.html
flexbox_flex-0-N-0.html
flexbox_flex-natural-mixed-basis-auto.html
flexbox_generated-container.html
flexbox_justifycontent-center-overflow.html
flexbox_min-height-auto.html
flexbox_min-width-auto.html
flexbox_stf-table-singleline.html
flexbox_visibility-collapse-line-wrapping.html
flexbox_visibility-collapse.html
flexbox_writing_mode_vertical_lays_out_contents_from_top_to_bottom.html
order/order-with-column-reverse.html
ttwf-reftest-flex-direction-row-reverse.html
ttwf-reftest-flex-inline.html
ttwf-reftest-flex-order.html
ttwf-reftest-flex-wrap-reverse.html
ttwf-reftest-flex-wrap.html
Comment 1 Radar WebKit Bug Importer 2014-09-11 14:47:32 PDT
<rdar://problem/18311645>
Comment 2 Marcos Chavarría Teijeiro (irc: chavaone) 2015-03-13 03:11:52 PDT
 css3/flexbox/csswg/flexbox_direction-row-reverse.html test is passing since r180652. This revision changes the test and updated the expected file.

Updating GTK Test Expectations on https://bugs.webkit.org/show_bug.cgi?id=142665
Comment 3 Michael Catanzaro 2018-02-27 15:32:41 PST
css3/flexbox/csswg/flexbox_flex-natural-mixed-basis-auto.html is passing r227528.
Comment 4 Carlos Alberto Lopez Perez 2020-04-15 12:03:12 PDT
The WPT tests https://wpt.live/css/css-flexbox/flexbox_stf-table-singleline.html and https://wpt.live/css/css-flexbox/flexbox_stf-table-singleline-2.html fail on WebKit

This tests are basically the same than LayoutTests/css3/flexbox/csswg/flexbox_stf-table-singleline.html

The failure on Safari its an unexpected blue/red background:
* Safari failure for css/css-flexbox/flexbox_stf-table-singleline.html: https://wpt.fyi/analyzer?screenshot=sha1%3A034d36646df057ddd5e8ff3ccd330431db7a0c65&screenshot=sha1%3A4693e37e925647c4bc3c064991bae5cbcec2b911
* Safari failure for css/css-flexbox/flexbox_stf-table-singleline-2.html: https://wpt.fyi/analyzer?screenshot=sha1%3A1585ef705a01ac8899c12877d8fb214a3d58a039&screenshot=sha1%3A4693e37e925647c4bc3c064991bae5cbcec2b911

This test lacks a "content" keyword so it's not documented what it exactly tests and the git log doesn't give you any interesting detail. So it's not obvious to me what it is exactly testing or why it fails on WebKit.
However, this test passes on Chrome and Firefox, WebKit its the only engine failing them.